mirrors/wayland
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wayland/wayland.git synced 2025-11-03 09:01:42 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

shm: add safety assertions

Browse source 
Catch any API mis-use with an assert. This should abort when the
user calls unreferences the pool more times than it's referenced.

Also change the refcount check to explicitly check for positive
counts. That makes the condition more readable.

Signed-off-by: Simon Ser <contact@emersion.fr>
This commit is contained in:
Simon Ser 2021-06-02 16:35:30 +02:00
parent ccc9612e82
commit 817fdb9009
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/wayland-shm.c
View file

@ -106,13 +106,15 @@ shm_pool_unref(struct wl_shm_pool *pool, bool external)
{ {
if (external) { if (external) {
pool->external_refcount--; pool->external_refcount--;
assert(pool->external_refcount >= 0);
if (pool->external_refcount == 0) if (pool->external_refcount == 0)
shm_pool_finish_resize(pool); shm_pool_finish_resize(pool);
} else { } else {
pool->internal_refcount--; pool->internal_refcount--;
assert(pool->internal_refcount >= 0);
} }
if (pool->internal_refcount + pool->external_refcount) if (pool->internal_refcount + pool->external_refcount > 0)
return; return;
munmap(pool->data, pool->size); munmap(pool->data, pool->size);