From 41b10c74589c5350931a688b0e828c85652dae45 Mon Sep 17 00:00:00 2001 From: Simon Ser Date: Wed, 15 Jun 2022 10:37:18 +0200 Subject: [PATCH] server: warn about global filtering consistency The filtering needs to be static given a client and a global, otherwise libwayland will misbehave. Signed-off-by: Simon Ser References: https://gitlab.freedesktop.org/wayland/wayland/-/merge_requests/241#note_1421888 --- src/wayland-server.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/wayland-server.c b/src/wayland-server.c index 4bcc9aeb..8e24b41b 100644 --- a/src/wayland-server.c +++ b/src/wayland-server.c @@ -1208,6 +1208,10 @@ wl_display_destroy(struct wl_display *display) * Setting the filter NULL will result in all globals being * advertised to all clients. The default is no filter. * + * The filter should be installed before any client connects and should always + * take the same decision given a client and a global. Not doing so will result + * in inconsistent filtering and broken wl_registry event sequences. + * * \memberof wl_display */ WL_EXPORT void