diff --git a/src/connection.c b/src/connection.c index f2928536..c5daca61 100644 --- a/src/connection.c +++ b/src/connection.c @@ -189,13 +189,16 @@ close_fds(struct wl_buffer *buffer, int max) buffer->tail += size; } -void +int wl_connection_destroy(struct wl_connection *connection) { + int fd = connection->fd; + close_fds(&connection->fds_out, -1); close_fds(&connection->fds_in, -1); - close(connection->fd); free(connection); + + return fd; } void diff --git a/src/wayland-private.h b/src/wayland-private.h index 67e87830..db76081c 100644 --- a/src/wayland-private.h +++ b/src/wayland-private.h @@ -86,7 +86,7 @@ int wl_interface_equal(const struct wl_interface *iface1, const struct wl_interface *iface2); struct wl_connection *wl_connection_create(int fd); -void wl_connection_destroy(struct wl_connection *connection); +int wl_connection_destroy(struct wl_connection *connection); void wl_connection_copy(struct wl_connection *connection, void *data, size_t size); void wl_connection_consume(struct wl_connection *connection, size_t size); diff --git a/src/wayland-server.c b/src/wayland-server.c index 674aecaf..7caeb302 100644 --- a/src/wayland-server.c +++ b/src/wayland-server.c @@ -670,7 +670,7 @@ wl_client_destroy(struct wl_client *client) wl_map_for_each(&client->objects, destroy_resource, &serial); wl_map_release(&client->objects); wl_event_source_remove(client->source); - wl_connection_destroy(client->connection); + close(wl_connection_destroy(client->connection)); wl_list_remove(&client->link); free(client); } diff --git a/tests/connection-test.c b/tests/connection-test.c index 659bf68b..4497128f 100644 --- a/tests/connection-test.c +++ b/tests/connection-test.c @@ -57,6 +57,7 @@ TEST(connection_create) connection = setup(s); wl_connection_destroy(connection); + close(s[0]); close(s[1]); } @@ -74,6 +75,7 @@ TEST(connection_write) assert(memcmp(message, buffer, sizeof message) == 0); wl_connection_destroy(connection); + close(s[0]); close(s[1]); } @@ -92,6 +94,7 @@ TEST(connection_data) wl_connection_consume(connection, sizeof message); wl_connection_destroy(connection); + close(s[0]); close(s[1]); } @@ -117,6 +120,7 @@ TEST(connection_queue) assert(memcmp(message, buffer + sizeof message, sizeof message) == 0); wl_connection_destroy(connection); + close(s[0]); close(s[1]); } @@ -147,8 +151,8 @@ setup_marshal_data(struct marshal_data *data) static void release_marshal_data(struct marshal_data *data) { - wl_connection_destroy(data->read_connection); - wl_connection_destroy(data->write_connection); + close(wl_connection_destroy(data->read_connection)); + close(wl_connection_destroy(data->write_connection)); } static void