mirrors/wayland
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wayland/wayland.git synced 2025-10-29 05:40:16 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

protocol: reorder wl_data_offer.source_actions and wl_data_device.enter

Browse source 
Most compositors send the wl_data_offer.source_actions event before the
wl_data_device.enter event, i.e. after creation of the data offer. This
contradicts to the wayland spec.

On the other hand, it's reasonable to send all the information useful to
the client before the enter event, rather than send mime types before the
enter event and source actions (that don't depend on drop target) after
the enter event.

On the client side, toolkits such as Qt and GTK already expect to see the
source actions before receiving the enter event.

Given all of that, this change adjusts the spec to match the behavior
observed in the compositors in the wild.

Signed-off-by: Vlad Zahorodnii <vlad.zahorodnii@kde.org>
This commit is contained in:
Vlad Zahorodnii 2022-09-21 17:42:58 +03:00 • committed by Simon Ser
parent 2aec8f59e9
commit 3815803633
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
protocol/wayland.xml
View file

@ -630,8 +630,9 @@
<event name="source_actions" since="3"> <event name="source_actions" since="3">
<description summary="notify the source-side available actions"> <description summary="notify the source-side available actions">
This event indicates the actions offered by the data source. It This event indicates the actions offered by the data source. It
will be sent right after wl_data_device.enter, or anytime the source will be sent immediately after creating the wl_data_offer object,
side changes its offered actions through wl_data_source.set_actions. or anytime the source side changes its offered actions through
wl_data_source.set_actions.
</description> </description>
<arg name="source_actions" type="uint" summary="actions offered by the data source" <arg name="source_actions" type="uint" summary="actions offered by the data source"
enum="wl_data_device_manager.dnd_action"/> enum="wl_data_device_manager.dnd_action"/>