From 2485a5c2749f636371b91c3f71c74d2d223d0020 Mon Sep 17 00:00:00 2001 From: orbea Date: Fri, 31 May 2019 08:09:35 -0700 Subject: [PATCH] Add a missing -pthread to fix compile with slibtool. When compiling wayland with slibtool instead of GNU libtool it will fail building libtest_runner with an undefined reference to pthread_join@@GLIBC_2.2.5. This is because -pthread (Or -lpthread) is missing from display_test. If its added the build succeeds as expected with slibtool and continues to work with libtool. Its likely that libtool is hiding this failure by silently adding the missing flag which is not uncommon... Exposed in commit aa51a833eb9b3d8fb58a64ff685b249d65ec35b5. Fixes https://gitlab.freedesktop.org/wayland/wayland/issues/91 Signed-off-by: orbea --- Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile.am b/Makefile.am index a41f959c..a0b11d5e 100644 --- a/Makefile.am +++ b/Makefile.am @@ -233,6 +233,7 @@ array_test_SOURCES = tests/array-test.c array_test_LDADD = libtest-runner.la client_test_SOURCES = tests/client-test.c client_test_LDADD = libtest-runner.la +display_test_CFLAGS = -pthread display_test_SOURCES = tests/display-test.c display_test_LDADD = libtest-runner.la nodist_display_test_SOURCES = \