mirrors/wayland
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/wayland/wayland.git synced 2026-04-14 08:22:20 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

cursor/os-compatibility: remove strcpy/strcat usage

Browse source 
These functions don't perform bounds checking, so they are easy to
misuse and complicate audits.

Signed-off-by: Simon Ser <contact@emersion.fr>
This commit is contained in:
Simon Ser 2022-06-04 22:56:36 +02:00
parent 355c8e885c
commit 0297c2c47a
1 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
cursor/os-compatibility.c
View file

@ -32,6 +32,7 @@
#include <fcntl.h> #include <fcntl.h>
#include <errno.h> #include <errno.h>
#include <string.h> #include <string.h>
#include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
#ifdef HAVE_MEMFD_CREATE #ifdef HAVE_MEMFD_CREATE
@ -118,6 +119,7 @@ os_create_anonymous_file(off_t size)
static const char template[] = "/wayland-cursor-shared-XXXXXX"; static const char template[] = "/wayland-cursor-shared-XXXXXX";
const char *path; const char *path;
char *name; char *name;
size_t name_size;
int fd; int fd;
#ifdef HAVE_MEMFD_CREATE #ifdef HAVE_MEMFD_CREATE
@ -139,12 +141,12 @@ os_create_anonymous_file(off_t size)
return -1; return -1;
} }
name = malloc(strlen(path) + sizeof(template)); name_size = strlen(path) + sizeof(template);
name = malloc(name_size);
if (!name) if (!name)
return -1; return -1;
strcpy(name, path); snprintf(name, name_size, "%s%s", path, template);
strcat(name, template);
fd = create_tmpfile_cloexec(name); fd = create_tmpfile_cloexec(name);