This is a bugfix release which adds support for wlroots 0.12.0.
Simon Ser (2):
build: bump wlroots dependency to 0.12.0
build: bump version to 1.5.1
-----BEGIN PGP SIGNATURE-----
iQIzBAABCAAdFiEENP+VJs/vDpejQOLkD9574OiPXkgFAl+qxYUACgkQD9574OiP
Xki2BBAAusN/5OJQfNQZ5UWVDff4ZRcp5Lty8xgloLtSFm8Rn2FRhaJjP1p+dsiw
2NBmoixnds/ziRMpyR/82HxQBpHXE/Zm73lamvQ695QwyFU1EcCaicMZrHAEl5op
b+ZySCH1zEEyZU5ltN1buVerkG0QM70aFjTau6h7BAfbVPJymTmSvXssIhdGt6Mb
RdHtxoDn++D4UmHDkt7+YznHnOskyw8SKHcbW2oVpf65a0NKyDhUnFV2mLCX89+u
zDC+3IDw+FV+Bu8bZHOxfgs1lkbnxD1DGCKf3v/n8BOvOxykygbS3ZMN2g907jmN
TDXpIOevL3b5OqDs3kMQayIPxCVpt9Iqqlkg6K99b2d4SgmjzNuHMFOp81u+nIre
U/RwO20U94fYWA2yut1MrtlMm0b12OTNoQYxQJZCzrIJuStmJ6rqonoJEFdfj7g6
wR3SdVkGEaBGzDjZTZVFibgt67TiSQc0RMaGEK5zi1wFnmKLR/O4cZvI1fOXUr5V
aVEuhlTeHjcUJTPKmFYiKxcz71260pyvy2VRIYcs3cke+086p5ZLMIgVZ7uEDm7x
40CH5i40Lb0J/acruMgEzZF6U0AmJyJmy37NF914v8Zc4uzjX8LX9J4GIZ93bcZd
PUvD/KfNOJi8eS7SMimjSbwo1yT7nTkCwXOXpqGNRdlhCM2XFFY=
=e4ID
-----END PGP SIGNATURE-----
Merge tag '1.5.1' into color-profiles
sway 1.5.1
This is a bugfix release which adds support for wlroots 0.12.0.
Simon Ser (2):
build: bump wlroots dependency to 0.12.0
build: bump version to 1.5.1
On warping to a cursor hint, update the pointer position we track as
well, so that on the next pointer rebase we don't send an unexpected
synthetic motion event to clients.
Fixes#5405.
(cherry picked from commit 6b9a9b6246)
In case when slurp is used to select part of screen or a window, if user aborts
the selection, grimshot will capture the whole screen instead of exiting. This
is fixed with check for empty variable.
(cherry picked from commit c65cd1cffa)
**Problem**
When I rename the workspace to something like "1:web",
`$mod+1` does not move to the "1:web" with the default config. This breaks
the expectation of i3 users.
**Cause**
The default Sway binding for `$mod+1` does not have the number
keyword:
```
bindsym $mod+1 workspace 1
```
Instead, the default Sway binding for `$mod+1` is
```
bindsym Mod1+1 workspace number $ws1
```
e6662df114
is the corresponding commit from i3.
(cherry picked from commit 585236f168)
Previously, we called output_disable prior to wlr_output_commit. This
mutates Sway's output state before the output commit actually succeeds.
This results in Sway's state getting out-of-sync with wlroots'.
An alternative fix [1] was to revert the changes made by output_disable
in case of failure. This is a little complicated. Instead, this patch
makes it so Sway's internal state is never changed before a successful
wlr_output commit.
We had two output flags: enabled and configured. However enabled was set
prior to the output becoming enabled, and was used to prevent the output
event handlers (specifically, the mode handler) from calling
apply_output_config again (infinite loop).
Rename enabled to enabling and use it exclusively for this purpose.
Rename configure to enabled, because that's what it really means.
[1]: https://github.com/swaywm/sway/pull/5521
Closes: https://github.com/swaywm/sway/issues/5483
(cherry picked from commit 5432f00adf)
xdg-shell doesn't allow clients to set the title to NULL, so we
shouldn't need to call wlr_foreign_toplevel_handle_v1_set_title with an
empty string to reset the old one.
Closes: https://github.com/swaywm/sway/issues/5488
(cherry picked from commit b5a35c484f)
If moving e.g. `T[app app]` into a new workspace with `workspace_layout
tabbed`, then post-move the tree in that workspace will be `T[T[app
app]]`. This still happens with horizontal or vertical workspace layout,
but is less visible since those containers have no decorations.
Fixes#5426.
(cherry picked from commit 92891fb1ed)
As per the Wayland spec [1]:
> The icon surface is an optional (can be NULL) surface that provides an
> icon to be moved around with the cursor.
However, as of now Sway "start_drag" signal handler does not starts the
DND session unless a non-NULL drag icons is provided. This patch fixes
it by skipping handling of the drag icon if it is null.
Fixes#5509
[1] https://wayland.freedesktop.org/docs/html/apa.html#protocol-spec-wl_data_device
Signed-off-by: Nick Diego Yamane <nickdiego@igalia.com>
This utilizes the newer Github issue templates. They allow for the user
to specify what type of issue they are submitting to allow for a more
specific issue template to be shown.
In addition to a hopefully easier to read/parse/follow bug report
template, this also include templates for enhancements and i3
compatibility. This also includes a link to the IRC under the section
title Questions.
For the three templates, the labels bug, enhancement, and i3-compat will
be automatically applied for the appropriate report to assist in
triaging.
Hopefully, this will result in less questions and issues for new window
management functionality on Github and allow for better quality issues
being submitted. At the very least, it allows us to outline our
stances for bugs, enhancements, and i3-compatibility in an easier to
read format.
xdg-shell doesn't allow clients to set the title to NULL, so we
shouldn't need to call wlr_foreign_toplevel_handle_v1_set_title with an
empty string to reset the old one.
Closes: https://github.com/swaywm/sway/issues/5488
If moving e.g. `T[app app]` into a new workspace with `workspace_layout
tabbed`, then post-move the tree in that workspace will be `T[T[app
app]]`. This still happens with horizontal or vertical workspace layout,
but is less visible since those containers have no decorations.
Fixes#5426.
It is not a part of the foreign-toplevel-management protocol to get the
class of a toplevel, only for getting the app_id.
For xwayland clients this is an issue because that means that you cannot
identify what application the toplevel refers to which is the point of
the app_id property.
By falling back to class when an app_id does not exist solves this problem.
Phoc also uses app_id and class interchangeably in their implementation
of foreign-toplevel-management, in fact they always do that and not only
for just this protocol.
c8d8a4c544/src/xwayland.c (L236)
wlr_drag installs grabs for the full duration of the drag, leading to
the drag target not being focused when the drag ends. This leads to
unexpected focus behavior, especially for the keyboard which requires
toggling focus away and back to set.
We can only fix the focus once the grabs are released, so refocus the
seat when the wlr_drag destroy event is received.
Closes: https://github.com/swaywm/sway/issues/5116
If a client commits a new size on its own, we create a transaction for
the resize like any other. However, this involves sending a configure
and waiting for the ack, and wlroots will not send configure events when
there has been no change. This leads to transactions timing out.
Instead, just mark the view ready immediately by size when the client
is already ready, so that we avoid waiting for an ack that will never
come.
Closes: https://github.com/swaywm/sway/issues/5490
Prior to this commit, a tablet device could trigger mouse button down
bindings if the pen was pressed on a surface that didn't bind tablet
handlers -- but it wouldn't if the surface did bind tablet handlers.
We should expose consistent behavior to users so that they don't have to
care about emulated vs. non-emulated input, so stop triggering bindings
for any non-pointer devices.
