Fix segfault in wlr_output_manager_v1_set_configuration

Calling wlr_output_manager_v1_set_configuration with an enabled output
and a NULL mode is incorrect if the output doesn't support modes.

When DPMS'ing an output, wlr_output_enable(output, false) is called.
This de-allocates the CRTC and sets wlr_output.current_mode to NULL.

Because we mark DPMS'ed outputs as enabled, we also need to provide a
correct output mode. Add a field to sway_output to hold the current
mode.

Closes: https://github.com/swaywm/wlroots/issues/1867
This commit is contained in:
Simon Ser 2019-10-26 14:00:37 +02:00 committed by Drew DeVault
parent 58a40ce07b
commit ec14a00e8c
4 changed files with 5 additions and 0 deletions

View file

@ -32,6 +32,8 @@ struct sway_output {
int lx, ly; // layout coords
int width, height; // transformed buffer size
enum wl_output_subpixel detected_subpixel;
// last applied mode when the output is DPMS'ed
struct wlr_output_mode *current_mode;
bool enabled, configured;
list_t *workspaces;