mirrors/sway
1
0
Fork 0
mirror of https://github.com/swaywm/sway.git synced 2026-04-26 06:46:26 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix swaynag off-by-one issues in button positions

Browse source 
Button positions are off in both the x and y directions.

This can be easily seen if we set the thickness of button borders
to 1 and set all the other margins, paddings, border thicknesses
and button gaps to 0.

Then, in the y direction, there is an one-pixel gap between the top
of swaynag and the top button borders, while the bottom button borders
are invisible. In the x direction, the right border of the dismiss
button is invisible, while the borders of adjacent buttons overlap
by one pixel.

Fixed by removing the explicit one-pixel offsets in the assignment
statements for button->x and button-y in the render_button function.
This commit is contained in:
Dimitris Triantafyllidis 2020-09-03 03:30:38 +03:00
parent 2c76923282
commit c14feee90a
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
swaynag/render.c
View file

@ -184,8 +184,8 @@ static uint32_t render_button(cairo_t *cairo, struct swaynag *swaynag,
return ideal_surface_height; return ideal_surface_height;
} }
button->x = *x - border - text_width - padding * 2 + 1; button->x = *x - border - text_width - padding * 2;
button->y = (int)(ideal_height - text_height) / 2 - padding + 1; button->y = (int)(ideal_height - text_height) / 2 - padding;
button->width = text_width + padding * 2; button->width = text_width + padding * 2;
button->height = text_height + padding * 2; button->height = text_height + padding * 2;