mirrors/sway
1
0
Fork 0
mirror of https://github.com/swaywm/sway.git synced 2025-10-28 05:40:16 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

input: fix udev_device leak

Browse source 
libinput_device_get_udev_device() returns a ref'ed handle:
https://wayland.freedesktop.org/libinput/doc/latest/api/group__device.html#gac13c64ba19fc19094cff0e5354a2a7ce

Similar to this wlroots MR:
https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/5074
This commit is contained in:
Simon Ser 2025-05-19 18:25:16 +02:00 • committed by Kenny Levinsen
parent 8fecf3aa8c
commit 5cfcd1c7c2
1 changed files with 16 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

26
sway/input/libinput.c
View file

@ -399,6 +399,19 @@ void sway_input_reset_libinput_device(struct sway_input_device *input_device) {
}
}
static bool sway_udev_device_is_builtin(struct udev_device *udev_device) {
const char *id_path = udev_device_get_property_value(udev_device, "ID_PATH");
if (!id_path) {
return false;
}
if (has_prefix(id_path, "platform-")) {
return true;
}
return has_prefix(id_path, "pci-") && strstr(id_path, "-platform-");
}
bool sway_libinput_device_is_builtin(struct sway_input_device *sway_device) {
if (!wlr_input_device_is_libinput(sway_device->wlr_device)) {
return false;
@ -412,14 +425,7 @@ bool sway_libinput_device_is_builtin(struct sway_input_device *sway_device) {
return false;
}
const char *id_path = udev_device_get_property_value(udev_device, "ID_PATH");
if (!id_path) {
return false;
}
if (has_prefix(id_path, "platform-")) {
return true;
}
return has_prefix(id_path, "pci-") && strstr(id_path, "-platform-");
bool is_builtin = sway_udev_device_is_builtin(udev_device);
udev_device_unref(udev_device);
return is_builtin;
}