mirrors/sway
1
0
Fork 0
mirror of https://github.com/swaywm/sway.git synced 2026-05-02 06:46:23 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix memory errors

Browse source 
- `swaylock` does not free the password buffer on ENTER
 - read_line: OOB write when a line in /proc/modules contains a
   terminating character at `size` position.
This commit is contained in:
Dan Robertson 2018-02-11 03:55:45 +00:00 • committed by Dan Robertson
parent 7c3b0ffc32
commit 397592adf1
No known key found for this signature in database
GPG key ID: 45C4A652C47E42A5
2 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
common/readline.c
View file

@ -36,7 +36,7 @@ char *read_line(FILE *file) {
} }
string[length++] = c; string[length++] = c;
} }
if (length + 1 == size) { if (length + 1 >= size) {
char *new_string = realloc(string, length + 1); char *new_string = realloc(string, length + 1);
if (!new_string) { if (!new_string) {
free(string); free(string);

1
swaylock/main.c
View file

@ -172,6 +172,7 @@ void notify_key(enum wl_keyboard_key_state state, xkb_keysym_t sym, uint32_t cod
redraw_screen = 1; redraw_screen = 1;
password_size = 1024; password_size = 1024;
free(password);
password = malloc(password_size); password = malloc(password_size);
password[0] = '\0'; password[0] = '\0';
break; break;