mirror of
				https://github.com/swaywm/sway.git
				synced 2025-11-03 09:01:43 -05:00 
			
		
		
		
	Check for NULL in container_update_title
Fixes crash when opening Firefox developer tools.
This commit is contained in:
		
							parent
							
								
									029c9b1796
								
							
						
					
					
						commit
						3202c45054
					
				
					 1 changed files with 6 additions and 1 deletions
				
			
		| 
						 | 
					@ -348,7 +348,7 @@ struct sway_container *container_view_create(struct sway_container *sibling,
 | 
				
			||||||
		swayc, title, sibling, sibling ? sibling->type : 0, sibling->name);
 | 
							swayc, title, sibling, sibling ? sibling->type : 0, sibling->name);
 | 
				
			||||||
	// Setup values
 | 
						// Setup values
 | 
				
			||||||
	swayc->sway_view = sway_view;
 | 
						swayc->sway_view = sway_view;
 | 
				
			||||||
	container_update_title(swayc, title ? title : "");
 | 
						container_update_title(swayc, title);
 | 
				
			||||||
	swayc->width = 0;
 | 
						swayc->width = 0;
 | 
				
			||||||
	swayc->height = 0;
 | 
						swayc->height = 0;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
| 
						 | 
					@ -660,9 +660,14 @@ static void container_notify_child_title_changed(
 | 
				
			||||||
 | 
					
 | 
				
			||||||
void container_update_title(struct sway_container *container,
 | 
					void container_update_title(struct sway_container *container,
 | 
				
			||||||
		const char *new_title) {
 | 
							const char *new_title) {
 | 
				
			||||||
 | 
						if (!new_title) {
 | 
				
			||||||
 | 
							new_title = "";
 | 
				
			||||||
 | 
						}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	if (container->name && strcmp(container->name, new_title) == 0) {
 | 
						if (container->name && strcmp(container->name, new_title) == 0) {
 | 
				
			||||||
		return;
 | 
							return;
 | 
				
			||||||
	}
 | 
						}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	if (container->name) {
 | 
						if (container->name) {
 | 
				
			||||||
		free(container->name);
 | 
							free(container->name);
 | 
				
			||||||
	}
 | 
						}
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue