Remove now-unused "input" argument of cmd_results_new

Patch tested by compiling with `__attribute__ ((format (printf, 2, 3)))`
applied to `cmd_results_new`.

String usage constants have been converted from pointers to arrays when
encountered. General handler format strings were sometimes modified to
include the old input string, especially for unknown command errors.
This commit is contained in:
M Stoeckl 2019-01-10 18:27:21 -05:00
parent 6d392150a7
commit 2a684cad5f
131 changed files with 503 additions and 601 deletions

View file

@ -69,7 +69,7 @@ struct cmd_results *cmd_bar(int argc, char **argv) {
wlr_log(WLR_DEBUG, "Creating bar: %s", argv[0]);
bar = default_bar_config();
if (!bar) {
return cmd_results_new(CMD_FAILURE, "bar",
return cmd_results_new(CMD_FAILURE,
"Unable to allocate bar state");
}
@ -83,7 +83,7 @@ struct cmd_results *cmd_bar(int argc, char **argv) {
// Create new bar with default values
struct bar_config *bar = default_bar_config();
if (!bar) {
return cmd_results_new(CMD_FAILURE, "bar",
return cmd_results_new(CMD_FAILURE,
"Unable to allocate bar state");
}
@ -93,8 +93,7 @@ struct cmd_results *cmd_bar(int argc, char **argv) {
if (bar->id) {
snprintf(bar->id, len, "bar-%d", config->bars->length - 1);
} else {
return cmd_results_new(CMD_FAILURE,
"bar", "Unable to allocate bar ID");
return cmd_results_new(CMD_FAILURE, "Unable to allocate bar ID");
}
// Set current bar
@ -117,7 +116,7 @@ struct cmd_results *cmd_bar(int argc, char **argv) {
}
}
}
return cmd_results_new(CMD_INVALID, "bar",
return cmd_results_new(CMD_INVALID,
"Can only be used in the config file.");
}