mirrors/sway
1
0
Fork 0
mirror of https://github.com/swaywm/sway.git synced 2026-04-29 06:46:22 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Don't schedule unnecessary output frames, and simplify damage functions

Browse source 
The `whole` argument has been removed from damage_surface_iterator
because it was never used. As this function now only deals with partial
damaging, it's been changed to return early if there is no damage and
avoids scheduling a frame unnecessarily.

With the removal of the `whole` argument, output_damage_from_view just
called output_damage_view with the same arguments, so I've combined
these into the one function and renamed it to
output_damage_view_surfaces.

Lastly, output_damage_whole_container_iterator is now removed as it was
never used. output_damage_whole_container just damages the container
including decorations and doesn't care about surfaces.
This commit is contained in:
Ryan Dwyer 2018-10-04 23:35:07 +10:00
parent 0d5c2f75b5
commit 26024ad434
3 changed files with 28 additions and 49 deletions
Download patch file Download diff file Expand all files Collapse all files

2
include/sway/output.h
View file

@ -75,7 +75,7 @@ void output_damage_whole(struct sway_output *output);
void output_damage_surface(struct sway_output *output, double ox, double oy,
struct wlr_surface *surface, bool whole);
void output_damage_from_view(struct sway_output *output,
void output_damage_view_surfaces(struct sway_output *output,
struct sway_view *view);
void output_damage_box(struct sway_output *output, struct wlr_box *box);

35
sway/desktop/output.c
View file

@ -392,17 +392,16 @@ void output_damage_whole(struct sway_output *output) {
static void damage_surface_iterator(struct sway_output *output,
struct wlr_surface *surface, struct wlr_box *_box, float rotation,
void *_data) {
bool *data = _data;
bool whole = *data;
void *data) {
if (!pixman_region32_not_empty(&surface->buffer_damage)) {
return;
}
struct wlr_box box = *_box;
scale_box(&box, output->wlr_output->scale);
int center_x = box.x + box.width/2;
int center_y = box.y + box.height/2;
if (pixman_region32_not_empty(&surface->buffer_damage)) {
enum wl_output_transform transform =
wlr_output_transform_invert(surface->current.transform);
@ -424,12 +423,6 @@ static void damage_surface_iterator(struct sway_output *output,
center_x, center_y);
wlr_output_damage_add(output->damage, &damage);
pixman_region32_fini(&damage);
}
if (whole) {
wlr_box_rotated_bounds(&box, rotation, &box);
wlr_output_damage_add_box(output->damage, &box);
}
wlr_output_schedule_frame(output->wlr_output);
}
@ -440,17 +433,12 @@ void output_damage_surface(struct sway_output *output, double ox, double oy,
damage_surface_iterator, &whole);
}
static void output_damage_view(struct sway_output *output,
struct sway_view *view, bool whole) {
void output_damage_view_surfaces(struct sway_output *output,
struct sway_view *view) {
if (!view_is_visible(view)) {
return;
}
output_view_for_each_surface(output, view, damage_surface_iterator, &whole);
}
void output_damage_from_view(struct sway_output *output,
struct sway_view *view) {
output_damage_view(output, view, false);
output_view_for_each_surface(output, view, damage_surface_iterator, NULL);
}
// Expecting an unscaled box in layout coordinates
@ -463,15 +451,6 @@ void output_damage_box(struct sway_output *output, struct wlr_box *_box) {
wlr_output_damage_add_box(output->damage, &box);
}
static void output_damage_whole_container_iterator(struct sway_container *con,
void *data) {
if (!sway_assert(con->view, "expected a view")) {
return;
}
struct sway_output *output = data;
output_damage_view(output, con->view, true);
}
void output_damage_whole_container(struct sway_output *output,
struct sway_container *con) {
// Pad the box by 1px, because the width is a double and might be a fraction

2
sway/tree/view.c
View file

@ -371,7 +371,7 @@ void view_close_popups(struct sway_view *view) {
void view_damage_from(struct sway_view *view) {
for (int i = 0; i < root->outputs->length; ++i) {
struct sway_output *output = root->outputs->items[i];
output_damage_from_view(output, view);
output_damage_view_surfaces(output, view);
}
}