mirror of
https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git
synced 2025-10-29 05:40:23 -04:00
pthread_create(&t->id, NULL, internal_thread_func, t) already
assigns the t->id parameter during the thread construction.
There shouldn't be need to redo this again.
If the system is configured with the thread sanitizer, with meson:
'meson -Db_sanitize=thread', it's apparent that the unnecessary
assignment only causes potential trouble:
08:06:11 MAKE_CHECK='1' /home/test/pulse/pulseaudio/build/src/tests/once-test
Running suite(s): Once
0%: Checks: 1, Failures: 0, Errors: 1
../src/tests/once-test.c:119:E:once:once_test:0: (after this point) Early exit with return value 66
WARNING: ThreadSanitizer: data race (pid=102975)
Read of size 8 at 0x7b0c000012c0 by main thread:
#0 pa_thread_join ../src/pulsecore/thread-posix.c:143 (libpulsecommon-13.99.so+0x8aca4)
#1 once_test ../src/tests/once-test.c:105 (once-test+0x2b13)
#2 srunner_run <null> (once-test+0x58e5)
#3 __libc_start_main <null> (libc.so.6+0x270b2)
Previous write of size 8 at 0x7b0c000012c0 by thread T61:
#0 internal_thread_func ../src/pulsecore/thread-posix.c:76 (libpulsecommon-13.99.so+0x8a715)
#1 <null> <null> (libtsan.so.0+0x2d1af)
Location is heap block of size 40 at 0x7b0c000012c0 allocated by main thread:
#0 calloc <null> (libtsan.so.0+0x305ca)
#1 pa_xmalloc0 ../src/pulse/xmalloc.c:74 (libpulse.so.0+0x6355b)
#2 _pa_xnew0_internal ../src/pulse/xmalloc.h:75 (libpulsecommon-13.99.so+0x8a267)
#3 pa_thread_new ../src/pulsecore/thread-posix.c:92 (libpulsecommon-13.99.so+0x8a828)
#4 once_test ../src/tests/once-test.c:102 (once-test+0x2a98)
#5 srunner_run <null> (once-test+0x58e5)
#6 __libc_start_main <null> (libc.so.6+0x270b2)
Thread T61 'once' (tid=110679, finished) created by main thread at:
#0 pthread_create <null> (libtsan.so.0+0x5ea99)
#1 pa_thread_new ../src/pulsecore/thread-posix.c:97 (libpulsecommon-13.99.so+0x8a8aa)
#2 once_test ../src/tests/once-test.c:102 (once-test+0x2a98)
#3 srunner_run <null> (once-test+0x58e5)
#4 __libc_start_main <null> (libc.so.6+0x270b2)
SUMMARY: ThreadSanitizer: data race ../src/pulsecore/thread-posix.c:143 in pa_thread_join
ThreadSanitizer: reported 1 warnings
Fix this warning by removing the unnecessary assignment.
Signed-off-by: Eero Nurkkala <eero.nurkkala@offcode.fi>
252 lines
5.1 KiB
C
252 lines
5.1 KiB
C
/***
|
|
This file is part of PulseAudio.
|
|
|
|
Copyright 2006 Lennart Poettering
|
|
Copyright 2006 Pierre Ossman <ossman@cendio.se> for Cendio AB
|
|
|
|
PulseAudio is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU Lesser General Public License as published
|
|
by the Free Software Foundation; either version 2.1 of the License,
|
|
or (at your option) any later version.
|
|
|
|
PulseAudio is distributed in the hope that it will be useful, but
|
|
WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
General Public License for more details.
|
|
|
|
You should have received a copy of the GNU Lesser General Public License
|
|
along with PulseAudio; if not, see <http://www.gnu.org/licenses/>.
|
|
***/
|
|
|
|
#ifdef HAVE_CONFIG_H
|
|
#include <config.h>
|
|
#endif
|
|
|
|
#include <pthread.h>
|
|
#include <sched.h>
|
|
#include <errno.h>
|
|
|
|
#ifdef __linux__
|
|
#include <sys/prctl.h>
|
|
#endif
|
|
|
|
#include <pulse/xmalloc.h>
|
|
#include <pulsecore/atomic.h>
|
|
#include <pulsecore/macro.h>
|
|
|
|
#include "thread.h"
|
|
|
|
struct pa_thread {
|
|
pthread_t id;
|
|
pa_thread_func_t thread_func;
|
|
void *userdata;
|
|
pa_atomic_t running;
|
|
bool joined;
|
|
char *name;
|
|
};
|
|
|
|
struct pa_tls {
|
|
pthread_key_t key;
|
|
};
|
|
|
|
static void thread_free_cb(void *p) {
|
|
pa_thread *t = p;
|
|
|
|
pa_assert(t);
|
|
|
|
if (!t->thread_func) {
|
|
/* This is a foreign thread, we need to free the struct */
|
|
pa_xfree(t->name);
|
|
pa_xfree(t);
|
|
}
|
|
}
|
|
|
|
PA_STATIC_TLS_DECLARE(current_thread, thread_free_cb);
|
|
|
|
static void* internal_thread_func(void *userdata) {
|
|
pa_thread *t = userdata;
|
|
pa_assert(t);
|
|
|
|
#ifdef __linux__
|
|
prctl(PR_SET_NAME, t->name);
|
|
#elif defined(HAVE_PTHREAD_SETNAME_NP) && defined(OS_IS_DARWIN)
|
|
pthread_setname_np(t->name);
|
|
#endif
|
|
|
|
PA_STATIC_TLS_SET(current_thread, t);
|
|
|
|
pa_atomic_inc(&t->running);
|
|
t->thread_func(t->userdata);
|
|
pa_atomic_sub(&t->running, 2);
|
|
|
|
return NULL;
|
|
}
|
|
|
|
pa_thread* pa_thread_new(const char *name, pa_thread_func_t thread_func, void *userdata) {
|
|
pa_thread *t;
|
|
|
|
pa_assert(thread_func);
|
|
|
|
t = pa_xnew0(pa_thread, 1);
|
|
t->name = pa_xstrdup(name);
|
|
t->thread_func = thread_func;
|
|
t->userdata = userdata;
|
|
|
|
if (pthread_create(&t->id, NULL, internal_thread_func, t) < 0) {
|
|
pa_xfree(t);
|
|
return NULL;
|
|
}
|
|
|
|
pa_atomic_inc(&t->running);
|
|
|
|
return t;
|
|
}
|
|
|
|
int pa_thread_is_running(pa_thread *t) {
|
|
pa_assert(t);
|
|
|
|
/* Unfortunately there is no way to tell whether a "foreign"
|
|
* thread is still running. See
|
|
* http://udrepper.livejournal.com/16844.html for more
|
|
* information */
|
|
pa_assert(t->thread_func);
|
|
|
|
return pa_atomic_load(&t->running) > 0;
|
|
}
|
|
|
|
void pa_thread_free(pa_thread *t) {
|
|
pa_assert(t);
|
|
|
|
pa_thread_join(t);
|
|
|
|
pa_xfree(t->name);
|
|
pa_xfree(t);
|
|
}
|
|
|
|
void pa_thread_free_nojoin(pa_thread *t) {
|
|
pa_assert(t);
|
|
|
|
pa_xfree(t->name);
|
|
pa_xfree(t);
|
|
}
|
|
|
|
int pa_thread_join(pa_thread *t) {
|
|
pa_assert(t);
|
|
pa_assert(t->thread_func);
|
|
|
|
if (t->joined)
|
|
return -1;
|
|
|
|
t->joined = true;
|
|
return pthread_join(t->id, NULL);
|
|
}
|
|
|
|
pa_thread* pa_thread_self(void) {
|
|
pa_thread *t;
|
|
|
|
if ((t = PA_STATIC_TLS_GET(current_thread)))
|
|
return t;
|
|
|
|
/* This is a foreign thread, let's create a pthread structure to
|
|
* make sure that we can always return a sensible pointer */
|
|
|
|
t = pa_xnew0(pa_thread, 1);
|
|
t->id = pthread_self();
|
|
t->joined = true;
|
|
pa_atomic_store(&t->running, 2);
|
|
|
|
PA_STATIC_TLS_SET(current_thread, t);
|
|
|
|
return t;
|
|
}
|
|
|
|
void* pa_thread_get_data(pa_thread *t) {
|
|
pa_assert(t);
|
|
|
|
return t->userdata;
|
|
}
|
|
|
|
void pa_thread_set_data(pa_thread *t, void *userdata) {
|
|
pa_assert(t);
|
|
|
|
t->userdata = userdata;
|
|
}
|
|
|
|
void pa_thread_set_name(pa_thread *t, const char *name) {
|
|
pa_assert(t);
|
|
|
|
pa_xfree(t->name);
|
|
t->name = pa_xstrdup(name);
|
|
|
|
#ifdef __linux__
|
|
prctl(PR_SET_NAME, name);
|
|
#elif defined(HAVE_PTHREAD_SETNAME_NP) && defined(OS_IS_DARWIN)
|
|
pthread_setname_np(name);
|
|
#endif
|
|
}
|
|
|
|
const char *pa_thread_get_name(pa_thread *t) {
|
|
pa_assert(t);
|
|
|
|
#ifdef __linux__
|
|
if (!t->name) {
|
|
t->name = pa_xmalloc(17);
|
|
|
|
if (prctl(PR_GET_NAME, t->name) >= 0)
|
|
t->name[16] = 0;
|
|
else {
|
|
pa_xfree(t->name);
|
|
t->name = NULL;
|
|
}
|
|
}
|
|
#elif defined(HAVE_PTHREAD_GETNAME_NP) && defined(OS_IS_DARWIN)
|
|
if (!t->name) {
|
|
t->name = pa_xmalloc0(17);
|
|
pthread_getname_np(t->id, t->name, 16);
|
|
}
|
|
#endif
|
|
|
|
return t->name;
|
|
}
|
|
|
|
void pa_thread_yield(void) {
|
|
#ifdef HAVE_PTHREAD_YIELD
|
|
pthread_yield();
|
|
#else
|
|
pa_assert_se(sched_yield() == 0);
|
|
#endif
|
|
}
|
|
|
|
pa_tls* pa_tls_new(pa_free_cb_t free_cb) {
|
|
pa_tls *t;
|
|
|
|
t = pa_xnew(pa_tls, 1);
|
|
|
|
if (pthread_key_create(&t->key, free_cb) < 0) {
|
|
pa_xfree(t);
|
|
return NULL;
|
|
}
|
|
|
|
return t;
|
|
}
|
|
|
|
void pa_tls_free(pa_tls *t) {
|
|
pa_assert(t);
|
|
|
|
pa_assert_se(pthread_key_delete(t->key) == 0);
|
|
pa_xfree(t);
|
|
}
|
|
|
|
void *pa_tls_get(pa_tls *t) {
|
|
pa_assert(t);
|
|
|
|
return pthread_getspecific(t->key);
|
|
}
|
|
|
|
void *pa_tls_set(pa_tls *t, void *userdata) {
|
|
void *r;
|
|
|
|
r = pthread_getspecific(t->key);
|
|
pa_assert_se(pthread_setspecific(t->key, userdata) == 0);
|
|
return r;
|
|
}
|