pulseaudio/src/modules/rtp
Erich Boleyn 64926ff6b3 RTP segfault/uninitialized resampler
Erich Boleyn <erich@uruk.org> wrote:

> Using RTP for multi-room music streaming, updated to Pulse 0.9.14 from
> 0.9.9, RTP reception new crashes with a segfault on all machines at
> the first "Updating sample rate" log message.
>
> Source of the segfault appears to be null pointer for
> "impl_update_rates" function in resampler routine, perhaps
> uninitialized resamplers in general?

A fresh look after work made the resampler initialization code pop out.

The problem is in the sink connection being made from
"module-rtp-recv.c", the "PA_SINK_INPUT_VARIABLE_RATE" flag should be
passed into "pa_sink_input_new", but is not there.  Made the change and
tested it, fixes the problem.  Checked and head-of- tree off of the
pulseaudio.org source browsing link does not have this fix either.

One-liner patch attached.
2009-02-06 02:12:20 +01:00
..
headerlist.c Remove $Id$ lines left over from SVN 2008-10-08 20:36:24 +01:00
headerlist.h Remove $Id$ lines left over from SVN 2008-10-08 20:36:24 +01:00
Makefile replace Makefile stub copies by symlinks 2008-09-11 01:41:08 +03:00
module-rtp-recv.c RTP segfault/uninitialized resampler 2009-02-06 02:12:20 +01:00
module-rtp-send.c make a couple of functions return proper error codes 2009-02-03 03:14:20 +01:00
rfc2327.txt add an RTP sender module 2006-04-14 23:47:33 +00:00
rfc2974.txt add an RTP sender module 2006-04-14 23:47:33 +00:00
rfc3550.txt add an RTP sender module 2006-04-14 23:47:33 +00:00
rfc3551.txt add an RTP sender module 2006-04-14 23:47:33 +00:00
rtp.c NetBSD needs to include sys/uio.h for some socket functions 2009-01-22 01:37:38 +01:00
rtp.h get rid of svn $ keywords 2008-06-18 23:23:21 +03:00
rtsp_client.c Remove $Id$ lines left over from SVN 2008-10-08 20:36:24 +01:00
rtsp_client.h Remove $Id$ lines left over from SVN 2008-10-08 20:36:24 +01:00
sap.c NetBSD needs to include sys/uio.h for some socket functions 2009-01-22 01:37:38 +01:00
sap.h get rid of svn $ keywords 2008-06-18 23:23:21 +03:00
sdp.c add a few more gcc warning flags and fix quite a few problems found by doing so 2008-08-19 22:39:54 +02:00
sdp.h get rid of svn $ keywords 2008-06-18 23:23:21 +03:00