mirrors/pulseaudio
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git synced 2025-12-16 08:56:40 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

core: Fix resource leak in core-util

Browse source 
https://scan7.coverity.com:8443/reports.htm#v10205/p10016/fileInstanceId=8477&defectInstanceId=3693&mergedDefectId=591269

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
This commit is contained in:
Peter Meerwald 2013-12-16 16:35:50 +01:00
parent c2e9f1fdec
commit ff9e9e05df
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/pulsecore/core-util.c
View file

@ -326,16 +326,20 @@ again:
goto fail; goto fail;
} }
if (!update_perms) if (!update_perms) {
pa_assert_se(pa_close(fd) >= 0);
return 0; return 0;
}
#ifdef HAVE_FCHOWN #ifdef HAVE_FCHOWN
if (uid == (uid_t) -1) if (uid == (uid_t) -1)
uid = getuid(); uid = getuid();
if (gid == (gid_t) -1) if (gid == (gid_t) -1)
gid = getgid(); gid = getgid();
if (fchown(fd, uid, gid) < 0) if (fchown(fd, uid, gid) < 0) {
pa_assert_se(pa_close(fd) >= 0);
goto fail; goto fail;
}
#endif #endif
#ifdef HAVE_FCHMOD #ifdef HAVE_FCHMOD