mirrors/pulseaudio
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git synced 2025-11-07 13:30:03 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

raop: Send initial timing packet to prime UDP connection tracking

Browse source 
In case the local UDP port is blocked by a firewall by default, send
an initial timing packet so the connection tracking will accept the
response packages.

Otherwise, the connection will fail with an 'RTSP/1.0 500 Internal
Server Error' after some timeout.

Fixes: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/issues/840
This commit is contained in:
StefanBruens 2020-04-10 18:44:13 +00:00 • committed by Tanu Kaskinen
parent 58482aa9c5
commit faac387ce9
1 changed files with 19 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

19
src/modules/raop/raop-client.c
View file

@ -681,6 +681,18 @@ static size_t handle_udp_timing_packet(pa_raop_client *c, const uint8_t packet[]
return written;
}
static void send_initial_udp_timing_packet(pa_raop_client *c) {
uint32_t data[6] = { 0 };
struct timeval tv;
uint64_t initial_time = 0;
initial_time = timeval_to_ntp(pa_rtclock_get(&tv));
data[4] = htonl(initial_time >> 32);
data[5] = htonl(initial_time & 0xffffffff);
send_udp_timing_packet(c, data, initial_time);
}
static int connect_udp_socket(pa_raop_client *c, int fd, uint16_t port) {
struct sockaddr_in sa4;
#ifdef HAVE_IPV6
@ -1077,6 +1089,13 @@ connect_finish:
pa_log_debug("Connection established (UDP;control_port=%d;timing_port=%d)", cport, tport);
/* Send an initial UDP packet so a connection tracking firewall
* knows the src_ip:src_port <-> dest_ip:dest_port relation
* and accepts the incoming timing packets.
*/
send_initial_udp_timing_packet(c);
pa_log_debug("Sent initial timing packet to UDP port %d", tport);
if (c->state_callback)
c->state_callback(PA_RAOP_CONNECTED, c->state_userdata);
}