mirrors/pulseaudio
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git synced 2025-11-12 13:30:10 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor stream attaching/detaching

Browse source 
Move repetitive code into convenience functions. No changes in
behaviour.
This commit is contained in:
Tanu Kaskinen 2016-12-08 01:59:05 +02:00
parent d404d8d1ab
commit f825239887
6 changed files with 112 additions and 63 deletions
Download patch file Download diff file Expand all files Collapse all files

25
src/pulsecore/sink-input.h
View file

@ -413,6 +413,31 @@ bool pa_sink_input_process_underrun(pa_sink_input *i);
pa_memchunk* pa_sink_input_get_silence(pa_sink_input *i, pa_memchunk *ret);
/* Calls the attach() callback if it's set. The input must be in detached
* state. */
void pa_sink_input_attach(pa_sink_input *i);
/* Calls the detach() callback if it's set and the input is attached. The input
* is allowed to be already detached, in which case this does nothing.
*
* The reason why this can be called for already-detached inputs is that when
* a filter sink's input is detached, it has to detach also all inputs
* connected to the filter sink. In case the filter sink's input was detached
* because the filter sink is being removed, those other inputs will be moved
* to another sink or removed, and moving and removing involve detaching the
* inputs, but the inputs at that point are already detached.
*
* XXX: Moving or removing an input also involves sending messages to the
* input's sink. If the input's sink is a detached filter sink, shouldn't
* sending messages to it be prohibited? The messages are processed in the
* root sink's IO thread, and when the filter sink is detached, it would seem
* logical to prohibit any interaction with the IO thread that isn't any more
* associated with the filter sink. Currently sending messages to detached
* filter sinks mostly works, because the filter sinks don't update their
* asyncmsgq pointer when detaching, so messages still find their way to the
* old IO thread. */
void pa_sink_input_detach(pa_sink_input *i);
/* Called from the main thread, from sink.c only. The normal way to set the
* sink input volume is to call pa_sink_input_set_volume(), but the flat volume
* logic in sink.c needs also a function that doesn't do all the extra stuff