mirrors/pulseaudio
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git synced 2025-11-03 09:01:50 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

core-util: Remove redundant check of directory permissions

Browse source 
Initially (in commit ef422fa4ae),
pa_make_secure_dir followed a simple principle: "make a directory, or,
if it exists, check that it is suitable". Later this evolved into "make
a directory, or, if it exists, ensure that it is suitable". But the
check remained.

The check is now neither sufficient nor necessary. On POSIX-compliant
systems, the fstat results being checked are actually post-conditions of
fchmod and fchown. And on systems implementing POSIX ACLs, fstat only
reflects a part of the information relevant to the security of the
directory permissions, so PulseAudio could accept an existing insecure
directory anyway.

Also, the check still fires on non-POSIX-compliant filesystems like CIFS.
As a user cannot do anything to fix it, just accept insecure permissions
in this case.
This commit is contained in:
Alexander E. Patrakov 2014-04-20 21:58:19 +06:00 • committed by Tanu Kaskinen
parent 5610d41482
commit f2f5dffb1d
1 changed files with 5 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

24
src/pulsecore/core-util.c
View file

@ -343,30 +343,16 @@ again:
#endif
#ifdef HAVE_FCHMOD
(void) fchmod(fd, m);
if (fchmod(fd, m) < 0) {
pa_assert_se(pa_close(fd) >= 0);
goto fail;
};
#endif
pa_assert_se(pa_close(fd) >= 0);
}
#endif
#ifdef HAVE_LSTAT
if (lstat(dir, &st) < 0)
#else
if (stat(dir, &st) < 0)
#endif
goto fail;
#ifndef OS_IS_WIN32
if (!S_ISDIR(st.st_mode) ||
(st.st_uid != uid) ||
(st.st_gid != gid) ||
((st.st_mode & 0777) != m)) {
errno = EACCES;
goto fail;
}
#else
pa_log_warn("Secure directory creation not supported on Win32.");
pa_log_warn("Secure directory creation not supported on this platform.");
#endif
return 0;