From ef864eeab0cc662f41a768fcb658a15e0e7f6648 Mon Sep 17 00:00:00 2001 From: Tanu Kaskinen Date: Fri, 10 Apr 2015 12:44:02 +0300 Subject: [PATCH] core-util: Filter out not-a-numbers in pa_atod() We don't and probably never will have any pa_atod() callers that would require "NaN" to be accepted, so let's filter those out in pa_atod(), instead of requiring the callers to handle not-a-numbers appropriately (which they generally forget to do). --- src/pulsecore/core-util.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/pulsecore/core-util.c b/src/pulsecore/core-util.c index 1dad507a4..452630654 100644 --- a/src/pulsecore/core-util.c +++ b/src/pulsecore/core-util.c @@ -23,6 +23,7 @@ #include #endif +#include #include #include #include @@ -2448,6 +2449,11 @@ int pa_atod(const char *s, double *ret_d) { return -1; } + if (isnan(f)) { + errno = EINVAL; + return -1; + } + *ret_d = f; return 0;