mirrors/pulseaudio
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git synced 2025-11-04 13:29:59 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

core: Ignore pa_shared_remove() return value

Browse source 
document behaviour of pa_shared_remove() in case name does not exist

Coverity ID: #1380672

thanks to Georg Chini for suggesting to swap patch title and commit message

Signed-off-by: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
This commit is contained in:
Peter Meerwald-Stadler 2017-03-07 16:09:56 +01:00
parent 976f7e9a61
commit eab0b9d83b
2 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/pulsecore/shared.c
View file

@ -111,6 +111,6 @@ int pa_shared_replace(pa_core *c, const char *name, void *data) {
pa_assert(c); pa_assert(c);
pa_assert(name); pa_assert(name);
pa_shared_remove(c, name); (void) pa_shared_remove(c, name);
return pa_shared_set(c, name, data); return pa_shared_set(c, name, data);
} }

4
src/pulsecore/shared.h
View file

@ -44,7 +44,9 @@ int pa_shared_set(pa_core *c, const char *name, void *data);
/* Remove the specified shared property. Return non-zero on failure */ /* Remove the specified shared property. Return non-zero on failure */
int pa_shared_remove(pa_core *c, const char *name); int pa_shared_remove(pa_core *c, const char *name);
/* A combination of pa_shared_remove() and pa_shared_set() */ /* A combination of pa_shared_remove() and pa_shared_set(); this function
* first tries to remove the property by this name and then sets the
* property. Return non-zero on failure. */
int pa_shared_replace(pa_core *c, const char *name, void *data); int pa_shared_replace(pa_core *c, const char *name, void *data);
/* Dump the current set of shared properties */ /* Dump the current set of shared properties */