mirror of
				https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git
				synced 2025-11-03 09:01:50 -05:00 
			
		
		
		
	core: Use after free in pa_sink_input_new_data_set_formats() and pa_source_output_new_data_set_formats()
intention is to free old data_req->formats before assigning new formats, discovered by coverity Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
This commit is contained in:
		
							parent
							
								
									4515f5d2ff
								
							
						
					
					
						commit
						e8ea0b8a79
					
				
					 2 changed files with 2 additions and 2 deletions
				
			
		| 
						 | 
				
			
			@ -161,7 +161,7 @@ bool pa_source_output_new_data_set_formats(pa_source_output_new_data *data, pa_i
 | 
			
		|||
    pa_assert(formats);
 | 
			
		||||
 | 
			
		||||
    if (data->req_formats)
 | 
			
		||||
        pa_idxset_free(formats, (pa_free_cb_t) pa_format_info_free);
 | 
			
		||||
        pa_idxset_free(data->req_formats, (pa_free_cb_t) pa_format_info_free);
 | 
			
		||||
 | 
			
		||||
    data->req_formats = formats;
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue