mirrors/pulseaudio
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git synced 2025-10-29 05:40:23 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

core: Use after free in pa_sink_input_new_data_set_formats() and pa_source_output_new_data_set_formats()

Browse source 
intention is to free old data_req->formats before assigning
new formats, discovered by coverity

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
This commit is contained in:
Peter Meerwald 2013-12-17 00:27:35 +01:00
parent 4515f5d2ff
commit e8ea0b8a79
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/pulsecore/sink-input.c
View file

@ -218,7 +218,7 @@ bool pa_sink_input_new_data_set_formats(pa_sink_input_new_data *data, pa_idxset
pa_assert(formats);
if (data->req_formats)
pa_idxset_free(formats, (pa_free_cb_t) pa_format_info_free);
pa_idxset_free(data->req_formats, (pa_free_cb_t) pa_format_info_free);
data->req_formats = formats;

2
src/pulsecore/source-output.c
View file

@ -161,7 +161,7 @@ bool pa_source_output_new_data_set_formats(pa_source_output_new_data *data, pa_i
pa_assert(formats);
if (data->req_formats)
pa_idxset_free(formats, (pa_free_cb_t) pa_format_info_free);
pa_idxset_free(data->req_formats, (pa_free_cb_t) pa_format_info_free);
data->req_formats = formats;