Revert "Revert "role-cork: Fix a minor leak""

This reverts commit a2c4bf22e0.

As Tanu points out, I'm stupid. The pa_xstrdup(n) was unnecessary
because pa_split() allocates a new string for us.
This commit is contained in:
Arun Raghavan 2012-07-03 18:04:48 +05:30
parent b7f7eb5657
commit ded196f93a

View file

@ -227,7 +227,7 @@ int pa__init(pa_module *m) {
char *n = NULL;
while ((n = pa_split(roles, ",", &split_state)))
if (n[0] != '\0')
pa_idxset_put(u->trigger_roles, pa_xstrdup(n), NULL);
pa_idxset_put(u->trigger_roles, n, NULL);
}
if (pa_idxset_isempty(u->trigger_roles)) {
pa_log_debug("Using role 'phone' as trigger role.");
@ -241,7 +241,7 @@ int pa__init(pa_module *m) {
char *n = NULL;
while ((n = pa_split(roles, ",", &split_state)))
if (n[0] != '\0')
pa_idxset_put(u->cork_roles, pa_xstrdup(n), NULL);
pa_idxset_put(u->cork_roles, n, NULL);
}
if (pa_idxset_isempty(u->cork_roles)) {
pa_log_debug("Using roles 'music' and 'video' as cork roles.");