mirrors/pulseaudio
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git synced 2025-11-04 13:29:59 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

document things that need to be fixed with FIXME

Browse source
This commit is contained in:
Lennart Poettering 2009-03-19 18:05:26 +01:00
parent 3762299beb
commit dd40006718
2 changed files with 7 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/modules/bluetooth/bluetooth-util.c
View file

@ -114,6 +114,8 @@ void pa_bluetooth_device_free(pa_bluetooth_device *d) {
static pa_bool_t device_is_loaded(pa_bluetooth_device *d) { static pa_bool_t device_is_loaded(pa_bluetooth_device *d) {
pa_assert(d); pa_assert(d);
/* FIXME: e83621724d7939b97b4f01f0d7e965d61ef8e55e, f1daa282f030e4e2381341e0f65faca47c4b891b is borked, probably needs to be reversed */
return d->device_info_valid && (d->audio_sink_info_valid || d->headset_info_valid); return d->device_info_valid && (d->audio_sink_info_valid || d->headset_info_valid);
} }
@ -123,6 +125,8 @@ static pa_bool_t device_is_audio(pa_bluetooth_device *d) {
pa_assert(d->device_info_valid); pa_assert(d->device_info_valid);
pa_assert(d->audio_sink_info_valid || d->headset_info_valid); pa_assert(d->audio_sink_info_valid || d->headset_info_valid);
/* FIXME: e83621724d7939b97b4f01f0d7e965d61ef8e55e, f1daa282f030e4e2381341e0f65faca47c4b891b is borked, probably needs to be reversed */
return d->device_info_valid > 0 && return d->device_info_valid > 0 &&
(d->audio_sink_info_valid > 0 || d->headset_info_valid > 0); (d->audio_sink_info_valid > 0 || d->headset_info_valid > 0);
} }

6
src/modules/bluetooth/module-bluetooth-device.c
View file

@ -876,7 +876,7 @@ static int hsp_process_render(struct userdata *u) {
pa_assert(l != 0); pa_assert(l != 0);
if (l < 0) { if (l < 0) {
if (errno == EINTR || errno == EAGAIN) if (errno == EINTR || errno == EAGAIN) /*** FIXME: EAGAIN handling borked ***/
continue; continue;
else { else {
pa_log_error("Failed to write data to SCO socket: %s", pa_cstrerror(errno)); pa_log_error("Failed to write data to SCO socket: %s", pa_cstrerror(errno));
@ -921,7 +921,7 @@ static int hsp_process_push(struct userdata *u) {
pa_memblock_release(memchunk.memblock); pa_memblock_release(memchunk.memblock);
if (l <= 0) { if (l <= 0) {
if (l < 0 && (errno == EINTR || errno == EAGAIN)) if (l < 0 && (errno == EINTR || errno == EAGAIN)) /*** FIXME: EAGAIN handling borked ***/
continue; continue;
else { else {
pa_log_error("Failed to read data from SCO socket: %s", l < 0 ? pa_cstrerror(errno) : "EOF"); pa_log_error("Failed to read data from SCO socket: %s", l < 0 ? pa_cstrerror(errno) : "EOF");
@ -1045,7 +1045,7 @@ static int a2dp_process_render(struct userdata *u) {
pa_assert(l != 0); pa_assert(l != 0);
if (l < 0) { if (l < 0) {
if (errno == EINTR || errno == EAGAIN) if (errno == EINTR || errno == EAGAIN) /*** FIXME: EAGAIN handling borked ***/
continue; continue;
else { else {
pa_log_error("Failed to write data to socket: %s", pa_cstrerror(errno)); pa_log_error("Failed to write data to socket: %s", pa_cstrerror(errno));