mirror of
https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git
synced 2025-12-22 08:56:52 -05:00
Fix undefined behaviour in pulseaudio --start.
Don't call pthread_join() to join a thread from a different process than the thread was created in. Doing so can lead to undefined behaviour. On OpenBSD, the symptom was a pulseaudio process with a single thread waiting forever for other threads to join. Since that process also held the autospawn lock, starting new pulseaudio processes with --start kept failing. The problem was analyzed with help from Philip Guenther. This patch adds a pa_thread_free_nojoin() function which can be used to free resources for a thread without a join, as suggested by Tanu Kaskinen. See https://bugs.freedesktop.org/show_bug.cgi?id=71738
This commit is contained in:
parent
303cff04eb
commit
d8e2b3a78c
3 changed files with 16 additions and 1 deletions
|
|
@ -127,6 +127,13 @@ void pa_thread_free(pa_thread *t) {
|
|||
pa_xfree(t);
|
||||
}
|
||||
|
||||
void pa_thread_free_nojoin(pa_thread *t) {
|
||||
pa_assert(t);
|
||||
|
||||
pa_xfree(t->name);
|
||||
pa_xfree(t);
|
||||
}
|
||||
|
||||
int pa_thread_join(pa_thread *t) {
|
||||
pa_assert(t);
|
||||
pa_assert(t->thread_func);
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue