From c49c9bd3aa829fff9a3de0037330a7ed2cbdb9a5 Mon Sep 17 00:00:00 2001 From: Felipe Sateler Date: Thu, 10 Sep 2015 21:42:48 -0300 Subject: [PATCH] Fix return code check of pa_append_to_home_dir It returns negative on error, zero on success. Found by coverity --- src/pulse/client-conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pulse/client-conf.c b/src/pulse/client-conf.c index 83331f882..47fe183a0 100644 --- a/src/pulse/client-conf.c +++ b/src/pulse/client-conf.c @@ -212,7 +212,7 @@ int pa_client_conf_load_cookie(pa_client_conf *c, uint8_t *cookie, size_t cookie if (r >= 0) return 0; - if (pa_append_to_home_dir(PA_NATIVE_COOKIE_FILE_FALLBACK, &fallback_path) > 0) { + if (pa_append_to_home_dir(PA_NATIVE_COOKIE_FILE_FALLBACK, &fallback_path) >= 0) { r = pa_authkey_load(fallback_path, false, cookie, cookie_length); pa_xfree(fallback_path); if (r >= 0)