mirrors/pulseaudio
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git synced 2025-11-04 13:29:59 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

ucm: Add a FIXME comment about bad error handling

Browse source
This commit is contained in:
Tanu Kaskinen 2013-11-18 18:48:05 +02:00
parent d1fd31d50f
commit bee86af3cc
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/modules/alsa/alsa-ucm.c
View file

@ -1125,6 +1125,9 @@ static void alsa_mapping_add_ucm_modifier(pa_alsa_mapping *m, pa_alsa_ucm_modifi
} }
if (channel_str) { if (channel_str) {
/* FIXME: channel_str is unsanitized input from the UCM configuration,
* we should do proper error handling instead of asserting.
* https://bugs.freedesktop.org/show_bug.cgi?id=71823 */
pa_assert_se(pa_atou(channel_str, &channels) == 0 && channels < PA_CHANNELS_MAX); pa_assert_se(pa_atou(channel_str, &channels) == 0 && channels < PA_CHANNELS_MAX);
pa_log_debug("Got channel count %" PRIu32 " for modifier", channels); pa_log_debug("Got channel count %" PRIu32 " for modifier", channels);
} }