A lot of more work to get the lock-free stuff in place

git-svn-id: file:///home/lennart/svn/public/pulseaudio/branches/lennart@1474 fefdeb5f-60dc-0310-8127-8f9354f1896f
This commit is contained in:
Lennart Poettering 2007-06-13 22:08:14 +00:00
parent 69115687ad
commit be4a882836
33 changed files with 908 additions and 694 deletions

View file

@ -121,7 +121,7 @@ static void io_callback(pa_mainloop_api *io, PA_GCC_UNUSED pa_io_event *e, PA_GC
pa_log("failed to get sink '%s'", u->sink_name);
else {
int i;
pa_cvolume cv = *pa_sink_get_volume(s, PA_MIXER_HARDWARE);
pa_cvolume cv = *pa_sink_get_volume(s);
#define DELTA (PA_VOLUME_NORM/20)
@ -134,7 +134,7 @@ static void io_callback(pa_mainloop_api *io, PA_GCC_UNUSED pa_io_event *e, PA_GC
cv.values[i] = PA_VOLUME_NORM;
}
pa_sink_set_volume(s, PA_MIXER_HARDWARE, &cv);
pa_sink_set_volume(s, &cv);
break;
case DOWN:
@ -145,20 +145,20 @@ static void io_callback(pa_mainloop_api *io, PA_GCC_UNUSED pa_io_event *e, PA_GC
cv.values[i] = PA_VOLUME_MUTED;
}
pa_sink_set_volume(s, PA_MIXER_HARDWARE, &cv);
pa_sink_set_volume(s, &cv);
break;
case MUTE:
pa_sink_set_mute(s, PA_MIXER_HARDWARE, 0);
pa_sink_set_mute(s, 0);
break;
case RESET:
pa_sink_set_mute(s, PA_MIXER_HARDWARE, 1);
pa_sink_set_mute(s, 1);
break;
case MUTE_TOGGLE:
pa_sink_set_mute(s, PA_MIXER_HARDWARE, !pa_sink_get_mute(s, PA_MIXER_HARDWARE));
pa_sink_set_mute(s, !pa_sink_get_mute(s));
break;
case INVALID:

View file

@ -114,7 +114,7 @@ static void io_callback(pa_mainloop_api *io, PA_GCC_UNUSED pa_io_event *e, PA_GC
pa_log("failed to get sink '%s'", u->sink_name);
else {
int i;
pa_cvolume cv = *pa_sink_get_volume(s, PA_MIXER_HARDWARE);
pa_cvolume cv = *pa_sink_get_volume(s);
#define DELTA (PA_VOLUME_NORM/20)
@ -127,7 +127,7 @@ static void io_callback(pa_mainloop_api *io, PA_GCC_UNUSED pa_io_event *e, PA_GC
cv.values[i] = PA_VOLUME_NORM;
}
pa_sink_set_volume(s, PA_MIXER_HARDWARE, &cv);
pa_sink_set_volume(s, &cv);
break;
case DOWN:
@ -138,12 +138,12 @@ static void io_callback(pa_mainloop_api *io, PA_GCC_UNUSED pa_io_event *e, PA_GC
cv.values[i] = PA_VOLUME_MUTED;
}
pa_sink_set_volume(s, PA_MIXER_HARDWARE, &cv);
pa_sink_set_volume(s, &cv);
break;
case MUTE_TOGGLE:
pa_sink_set_mute(s, PA_MIXER_HARDWARE, !pa_sink_get_mute(s, PA_MIXER_HARDWARE));
pa_sink_set_mute(s, !pa_sink_get_mute(s));
break;
case INVALID:

View file

@ -33,17 +33,19 @@
#include <fcntl.h>
#include <unistd.h>
#include <limits.h>
#include <sys/poll.h>
#include <pulse/timeval.h>
#include <pulse/xmalloc.h>
#include <pulsecore/macro.h>
#include <pulsecore/iochannel.h>
#include <pulsecore/sink.h>
#include <pulsecore/module.h>
#include <pulsecore/core-util.h>
#include <pulsecore/core-error.h>
#include <pulsecore/modargs.h>
#include <pulsecore/log.h>
#include <pulsecore/thread.h>
#include "module-null-sink-symdef.h"
@ -65,7 +67,9 @@ struct userdata {
pa_module *module;
pa_sink *sink;
pa_thread *thread;
pa_asyncmsgq *asyncmsgq;
size_t block_size;
struct timeval timestamp;
};
@ -79,85 +83,74 @@ static const char* const valid_modargs[] = {
NULL
};
static int sink_process_msg(pa_msgobject *o, int code, void *data, pa_memchunk *chunk) {
struct userdata *u = PA_SINK(o)->userdata;
switch (code) {
case PA_SINK_MESSAGE_SET_STATE:
if (PA_PTR_TO_UINT(data) == PA_SINK_RUNNING)
pa_gettimeofday(&u->timestamp);
break;
case PA_SINK_MESSAGE_GET_LATENCY: {
struct timeval now;
pa_gettimeofday(&now);
if (pa_timeval_cmp(&u->timestamp, &now) > 0)
*((pa_usec_t*) data) = 0;
else
*((pa_usec_t*) data) = pa_timeval_diff(&u->timestamp, &now);
break;
}
}
return pa_sink_process_msg(o, code, data, chunk);
}
static void thread_func(void *userdata) {
struct userdata *u = userdata;
int quit = 0;
struct pollfd pollfd;
int running = 1;
pa_assert(u);
pa_log_debug("Thread starting up");
pa_gettimeofday(&u->timestamp);
memset(&pollfd, 0, sizeof(pollfd));
pollfd.fd = pa_asyncmsgq_get_fd(u->sink->asyncmsgq, PA_ASYNCQ_POP);
pollfd.fd = pa_asyncmsgq_get_fd(u->asyncmsgq);
pollfd.events = POLLIN;
pa_gettimeofday(u->timestamp);
for (;;) {
pa_msgobject *object;
int code;
void *data, *object;
void *data;
pa_memchunk chunk;
int r, timeout;
struct timeval now;
/* Check whether there is a message for us to process */
if (pa_asyncmsgq_get(u->sink->asyncmsgq, &object, &code, &data) == 0) {
if (pa_asyncmsgq_get(u->asyncmsgq, &object, &code, &data, &chunk, 0) == 0) {
int ret;
/* Now process these messages our own way */
if (!object) {
switch (code) {
case PA_MESSAGE_SHUTDOWN:
goto finish;
default:
pa_sink_process_msg(u->sink->asyncmsgq, object, code, data);
}
} else if (object == u->sink) {
switch (code) {
case PA_SINK_MESSAGE_STOP:
pa_assert(running);
running = 0;
break;
case PA_SINK_MESSAGE_START:
pa_assert(!running);
running = 1;
pa_gettimeofday(u->timestamp);
break;
case PA_SINK_MESSAGE_GET_LATENCY:
if (pa_timeval_cmp(&u->timestamp, &now) > 0)
*((pa_usec_t*) data) = 0;
else
*((pa_usec_t*) data) = pa_timeval_diff(&u->timestamp, &now);
break;
/* ... */
default:
pa_sink_process_msg(u->sink->asyncmsgq, object, code, data);
}
if (!object && code == PA_MESSAGE_SHUTDOWN) {
pa_asyncmsgq_done(u->asyncmsgq, 0);
goto finish;
}
pa_asyncmsgq_done(u->sink->asyncmsgq);
ret = pa_asyncmsgq_dispatch(object, code, data, &chunk);
pa_asyncmsgq_done(u->asyncmsgq, ret);
continue;
}
/* Render some data and drop it immediately */
if (running) {
if (u->sink->thread_info.state == PA_SINK_RUNNING) {
pa_gettimeofday(&now);
if (pa_timeval_cmp(u->timestamp, &now) <= 0) {
pa_memchunk chunk;
if (pa_timeval_cmp(&u->timestamp, &now) <= 0) {
size_t l;
if (pa_sink_render(u->sink, u->block_size, &chunk) >= 0) {
@ -179,11 +172,11 @@ static void thread_func(void *userdata) {
/* Hmm, nothing to do. Let's sleep */
if (pa_asyncmsgq_before_poll(u->sink->asyncmsgq) < 0)
if (pa_asyncmsgq_before_poll(u->asyncmsgq) < 0)
continue;
r = poll(&pollfd, 1, timeout);
pa_asyncmsgq_after_poll(u->sink->asyncmsgq);
pa_asyncmsgq_after_poll(u->asyncmsgq);
if (r < 0) {
if (errno == EINTR)
@ -199,8 +192,8 @@ static void thread_func(void *userdata) {
fail:
/* We have to continue processing messages until we receive the
* SHUTDOWN message */
pa_asyncmsgq_post(u->core->asyncmsgq, u->core, PA_CORE_MESSAGE_UNLOAD_MODULE, pa_module_ref(u->module), NULL, pa_module_unref);
pa_asyncmsgq_wait_for(PA_MESSAGE_SHUTDOWN);
pa_asyncmsgq_post(u->core->asyncmsgq, PA_MSGOBJECT(u->core), PA_CORE_MESSAGE_UNLOAD_MODULE, u->module, NULL, NULL);
pa_asyncmsgq_wait_for(u->asyncmsgq, PA_MESSAGE_SHUTDOWN);
finish:
pa_log_debug("Thread shutting down");
@ -231,20 +224,24 @@ int pa__init(pa_core *c, pa_module*m) {
u->module = m;
m->userdata = u;
pa_assert_se(u->asyncmsgq = pa_asyncmsgq_new(0));
if (!(u->sink = pa_sink_new(c, __FILE__, pa_modargs_get_value(ma, "sink_name", DEFAULT_SINK_NAME), 0, &ss, &map))) {
pa_log("Failed to create sink.");
goto fail;
}
u->sink->parent.process_msg = sink_process_msg;
u->sink->userdata = u;
pa_sink_set_owner(u->sink, m);
pa_sink_set_module(u->sink, m);
pa_sink_set_asyncmsgq(u->sink, u->asyncmsgq);
pa_sink_set_description(u->sink, pa_modargs_get_value(ma, "description", "NULL sink"));
u->block_size = pa_bytes_per_second(&ss) / 20; /* 50 ms */
if (u->block_size <= 0)
u->block_size = pa_frame_size(&ss);
if (!(u->thread = pa_thread_new(thread_func, u))) {
pa_log("Failed to create thread.");
goto fail;
@ -272,14 +269,19 @@ void pa__done(pa_core *c, pa_module*m) {
if (!(u = m->userdata))
return;
pa_sink_disconnect(u->sink);
if (u->sink)
pa_sink_disconnect(u->sink);
if (u->thread) {
pa_asyncmsgq_send(u->sink->asyncmsgq, PA_SINK_MESSAGE_SHUTDOWN, NULL);
pa_asyncmsgq_send(u->asyncmsgq, NULL, PA_MESSAGE_SHUTDOWN, NULL, NULL);
pa_thread_free(u->thread);
}
pa_sink_unref(u->sink);
if (u->asyncmsgq)
pa_asyncmsgq_free(u->asyncmsgq);
if (u->sink)
pa_sink_unref(u->sink);
pa_xfree(u);
}

View file

@ -34,6 +34,8 @@
#include <fcntl.h>
#include <unistd.h>
#include <limits.h>
#include <sys/ioctl.h>
#include <sys/poll.h>
#include <pulse/xmalloc.h>
@ -44,6 +46,7 @@
#include <pulsecore/core-util.h>
#include <pulsecore/modargs.h>
#include <pulsecore/log.h>
#include <pulsecore/thread.h>
#include "module-pipe-sink-symdef.h"
@ -65,9 +68,12 @@ struct userdata {
pa_core *core;
pa_module *module;
pa_sink *sink;
pa_thread *thread;
pa_asyncmsgq *asyncmsgq;
char *filename;
int fd;
pa_thread *thread;
pa_memchunk memchunk;
};
static const char* const valid_modargs[] = {
@ -80,109 +86,99 @@ static const char* const valid_modargs[] = {
NULL
};
enum {
POLLFD_ASYNCQ,
POLLFD_FIFO,
POLLFD_MAX,
};
static int sink_process_msg(pa_msgobject *o, int code, void *data, pa_memchunk *chunk) {
struct userdata *u = PA_SINK(o)->userdata;
switch (code) {
case PA_SINK_MESSAGE_GET_LATENCY: {
size_t n = 0;
int l;
if (ioctl(u->fd, TIOCINQ, &l) >= 0 && l > 0)
n = (size_t) l;
n += u->memchunk.length;
*((pa_usec_t*) data) = pa_bytes_to_usec(n, &u->sink->sample_spec);
break;
}
}
return pa_sink_process_msg(o, code, data, chunk);
}
static void thread_func(void *userdata) {
enum {
POLLFD_ASYNCQ,
POLLFD_FIFO,
POLLFD_MAX,
};
struct userdata *u = userdata;
int quit = 0;
struct pollfd pollfd[POLLFD_MAX];
int running = 1, underrun = 0;
pa_memchunk memchunk;
int underrun = 0;
int write_type = 0;
pa_assert(u);
pa_log_debug("Thread starting up");
pa_memchunk_reset(&u->memchunk);
memset(&pollfd, 0, sizeof(pollfd));
pollfd[POLLFD_ASYNCQ].fd = pa_asyncmsgq_get_fd(u->sink->asyncmsgq, PA_ASYNCQ_POP);
pollfd[POLLFD_ASYNCQ].fd = pa_asyncmsgq_get_fd(u->asyncmsgq);
pollfd[POLLFD_ASYNCQ].events = POLLIN;
pollfd[POLLFD_FIFO].fd = u->fd;
memset(&memchunk, 0, sizeof(memchunk));
for (;;) {
pa_msgobject *object;
int code;
void *object, *data;
void *data;
pa_memchunk chunk;
int r;
struct timeval now;
/* Check whether there is a message for us to process */
if (pa_asyncmsgq_get(u->sink->asyncmsgq, &object, &code, &data) == 0) {
if (pa_asyncmsgq_get(u->asyncmsgq, &object, &code, &data, &chunk, 0) == 0) {
int ret;
/* Now process these messages our own way */
if (!object) {
switch (code) {
case PA_SINK_MESSAGE_SHUTDOWN:
goto finish;
default:
pa_sink_process_msg(u->sink->asyncmsgq, object, code, data);
}
} else if (object == u->sink) {
case PA_SINK_MESSAGE_STOP:
pa_assert(running);
running = 0;
break;
case PA_SINK_MESSAGE_START:
pa_assert(!running);
running = 1;
break;
case PA_SINK_MESSAGE_GET_LATENCY: {
size_t n = 0;
int l;
if (ioctl(u->fd, TIOCINQ, &l) >= 0 && l > 0)
n = (size_t) l;
n += memchunk.length;
*((pa_usec_t*) data) pa_bytes_to_usec(n, &u->sink->sample_spec);
break;
}
/* ... */
default:
pa_sink_process_msg(u->sink->asyncmsgq, object, code, data);
if (!object && code == PA_MESSAGE_SHUTDOWN) {
pa_asyncmsgq_done(u->asyncmsgq, 0);
goto finish;
}
pa_asyncmsgq_done(u->sink->asyncmsgq);
ret = pa_asyncmsgq_dispatch(object, code, data, &chunk);
pa_asyncmsgq_done(u->asyncmsgq, ret);
continue;
}
/* Render some data and write it to the fifo */
if (running && (pollfd[POLLFD_FIFO].revents || underrun)) {
if (u->sink->thread_info.state == PA_SINK_RUNNING && (pollfd[POLLFD_FIFO].revents || underrun)) {
if (chunk.length <= 0)
pa_sink_render(u->fd, PIPE_BUF, &chunk);
if (u->memchunk.length <= 0)
pa_sink_render(u->sink, PIPE_BUF, &u->memchunk);
underrun = chunk.length <= 0;
underrun = u->memchunk.length <= 0;
if (!underrun) {
ssize_t l;
void *p;
p = pa_memblock_acquire(u->memchunk.memblock);
l = pa_write(u->fd, (uint8_t*) p + u->memchunk.index, u->memchunk.length);
pa_memblock_release(p);
l = pa_write(u->fd, (uint8_t*) p + u->memchunk.index, u->memchunk.length, &write_type);
pa_memblock_release(u->memchunk.memblock);
if (l < 0) {
if (errno != EINTR && errno != EAGAIN) {
if (errno == EINTR)
continue;
else if (errno != EAGAIN) {
pa_log("Failed to write data to FIFO: %s", pa_cstrerror(errno));
goto fail;
}
} else {
u->memchunk.index += l;
@ -190,24 +186,24 @@ static void thread_func(void *userdata) {
if (u->memchunk.length <= 0) {
pa_memblock_unref(u->memchunk.memblock);
u->memchunk.memblock = NULL;
pa_memchunk_reset(&u->memchunk);
}
}
pollfd[POLLFD_FIFO].revents = 0;
continue;
pollfd[POLLFD_FIFO].revents = 0;
continue;
}
}
}
pollfd[POLLFD_FIFO].events = running && !underrun ? POLLOUT : 0;
pollfd[POLLFD_FIFO].events = (u->sink->thread_info.state == PA_SINK_RUNNING && !underrun) ? POLLOUT : 0;
/* Hmm, nothing to do. Let's sleep */
if (pa_asyncmsgq_before_poll(u->sink->asyncmsgq) < 0)
if (pa_asyncmsgq_before_poll(u->asyncmsgq) < 0)
continue;
r = poll(&pollfd, 1, 0);
pa_asyncmsgq_after_poll(u->sink->asyncmsgq);
r = poll(pollfd, POLLFD_MAX, -1);
pa_asyncmsgq_after_poll(u->asyncmsgq);
if (r < 0) {
if (errno == EINTR)
@ -217,19 +213,19 @@ static void thread_func(void *userdata) {
goto fail;
}
if (pollfd[POLLFD_FIFO].revents & ~POLLIN) {
if (pollfd[POLLFD_FIFO].revents & ~POLLOUT) {
pa_log("FIFO shutdown.");
goto fail;
}
pa_assert(pollfd[POLLFD_ASYNCQ].revents & ~POLLIN == 0);
pa_assert((pollfd[POLLFD_ASYNCQ].revents & ~POLLIN) == 0);
}
fail:
/* We have to continue processing messages until we receive the
* SHUTDOWN message */
pa_asyncmsgq_post(u->core->asyncmsgq, u->core, PA_CORE_MESSAGE_UNLOAD_MODULE, pa_module_ref(u->module), pa_module_unref);
pa_asyncmsgq_wait_for(PA_SINK_MESSAGE_SHUTDOWN);
pa_asyncmsgq_post(u->core->asyncmsgq, PA_MSGOBJECT(u->core), PA_CORE_MESSAGE_UNLOAD_MODULE, u->module, NULL, NULL);
pa_asyncmsgq_wait_for(u->asyncmsgq, PA_MESSAGE_SHUTDOWN);
finish:
pa_log_debug("Thread shutting down");
@ -253,23 +249,22 @@ int pa__init(pa_core *c, pa_module*m) {
ss = c->default_sample_spec;
if (pa_modargs_get_sample_spec_and_channel_map(ma, &ss, &map, PA_CHANNEL_MAP_DEFAULT) < 0) {
pa_log("Invalid sample format specification");
pa_log("Invalid sample format specification or channel map");
goto fail;
}
u = pa_xnew0(struct userdata, 1);
u->core = c;
u->module = m;
u->filename = pa_xstrdup(pa_modargs_get_value(ma, "file", DEFAULT_FIFO_NAME));
u->fd = fd;
u->memchunk.memblock = NULL;
u->memchunk.length = 0;
m->userdata = u;
mkfifo(u->filename, 0666);
pa_assert_se(u->asyncmsgq = pa_asyncmsgq_new(0));
u->filename = pa_xstrdup(pa_modargs_get_value(ma, "file", DEFAULT_FILE_NAME));
if ((u->fd = open(u->filename, O_RDWR)) < 0) {
pa_log("open('%s'): %s", p, pa_cstrerror(errno));
mkfifo(u->filename, 0666);
if ((u->fd = open(u->filename, O_RDWR|O_NOCTTY)) < 0) {
pa_log("open('%s'): %s", u->filename, pa_cstrerror(errno));
goto fail;
}
@ -277,12 +272,12 @@ int pa__init(pa_core *c, pa_module*m) {
pa_make_nonblock_fd(u->fd);
if (fstat(u->fd, &st) < 0) {
pa_log("fstat('%s'): %s", p, pa_cstrerror(errno));
pa_log("fstat('%s'): %s", u->filename, pa_cstrerror(errno));
goto fail;
}
if (!S_ISFIFO(st.st_mode)) {
pa_log("'%s' is not a FIFO.", p);
pa_log("'%s' is not a FIFO.", u->filename);
goto fail;
}
@ -291,9 +286,12 @@ int pa__init(pa_core *c, pa_module*m) {
goto fail;
}
u->sink->parent.process_msg = sink_process_msg;
u->sink->userdata = u;
pa_sink_set_owner(u->sink, m);
pa_sink_set_description(u->sink, t = pa_sprintf_malloc("Unix FIFO sink '%s'", p));
pa_sink_set_module(u->sink, m);
pa_sink_set_asyncmsgq(u->sink, u->asyncmsgq);
pa_sink_set_description(u->sink, t = pa_sprintf_malloc("Unix FIFO sink '%s'", u->filename));
pa_xfree(t);
if (!(u->thread = pa_thread_new(thread_func, u))) {
@ -316,20 +314,26 @@ fail:
void pa__done(pa_core *c, pa_module*m) {
struct userdata *u;
pa_assert(c);
pa_assert(m);
if (!(u = m->userdata))
return;
pa_sink_disconnect(u->sink);
if (u->sink)
pa_sink_disconnect(u->sink);
if (u->thread) {
pa_asyncmsgq_send(u->sink->asyncmsgq, PA_SINK_MESSAGE_SHUTDOWN, NULL);
pa_asyncmsgq_send(u->asyncmsgq, NULL, PA_MESSAGE_SHUTDOWN, NULL, NULL);
pa_thread_free(u->thread);
}
pa_sink_unref(u->sink);
if (u->asyncmsgq)
pa_asyncmsgq_free(u->asyncmsgq);
if (u->sink)
pa_sink_unref(u->sink);
if (u->memchunk.memblock)
pa_memblock_unref(u->memchunk.memblock);

View file

@ -179,7 +179,7 @@ int pa__init(pa_core *c, pa_module*m) {
goto fail;
}
u->source->userdata = u;
pa_source_set_owner(u->source, m);
pa_source_set_module(u->source, m);
pa_source_set_description(u->source, t = pa_sprintf_malloc("Unix FIFO source '%s'", p));
pa_xfree(t);