mirrors/pulseaudio
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git synced 2025-11-05 13:29:57 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

bluetooth: Remove pa_bluetooth_discovery_sync().

Browse source 
pa_bluetooth_discovery_sync() waited until all pending method calls
had completed. I don't understand what the benefit of that could be,
so I removed the function. We should avoid blocking as much as
possible, and the code that used pa_bluetooth_discovery_sync() didn't
look like it really needed to wait for anything.
This commit is contained in:
Tanu Kaskinen 2012-12-17 09:01:03 +02:00
parent de73a3ed98
commit baa62fb615
3 changed files with 4 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/modules/bluetooth/module-bluetooth-discover.c
View file

@ -40,15 +40,14 @@
PA_MODULE_AUTHOR("Joao Paulo Rechi Vita");
PA_MODULE_DESCRIPTION("Detect available bluetooth audio devices and load bluetooth audio drivers");
PA_MODULE_VERSION(PACKAGE_VERSION);
PA_MODULE_USAGE("async=<Asynchronous initialization?> "
"sco_sink=<name of sink> "
PA_MODULE_USAGE("sco_sink=<name of sink> "
"sco_source=<name of source> ");
PA_MODULE_LOAD_ONCE(TRUE);
static const char* const valid_modargs[] = {
"sco_sink",
"sco_source",
"async",
"async", /* deprecated */
NULL
};
@ -128,7 +127,6 @@ static pa_hook_result_t load_module_for_device(pa_bluetooth_discovery *y, const
int pa__init(pa_module* m) {
struct userdata *u;
pa_modargs *ma = NULL;
pa_bool_t async = FALSE;
pa_assert(m);
@ -137,10 +135,8 @@ int pa__init(pa_module* m) {
goto fail;
}
if (pa_modargs_get_value_boolean(ma, "async", &async) < 0) {
pa_log("Failed to parse async argument.");
goto fail;
}
if (pa_modargs_get_value(ma, "async", NULL))
pa_log_warn("The 'async' argument is deprecated and does nothing.");
m->userdata = u = pa_xnew0(struct userdata, 1);
u->module = m;
@ -155,9 +151,6 @@ int pa__init(pa_module* m) {
u->slot = pa_hook_connect(pa_bluetooth_discovery_hook(u->discovery, PA_BLUETOOTH_HOOK_DEVICE_CONNECTION_CHANGED),
PA_HOOK_NORMAL, (pa_hook_cb_t) load_module_for_device, u);
if (!async)
pa_bluetooth_discovery_sync(u->discovery);
return 0;
fail: