From ac7f2d96c7fc2d83f4a9fd74724ceaa9a634fe72 Mon Sep 17 00:00:00 2001 From: Tanu Kaskinen Date: Mon, 18 Jan 2021 17:36:20 +0200 Subject: [PATCH] alsa-mixer: Accept negative max_dB when using decibel fixes Sometimes decibel fixes are used as a trick to set a maximum hardware volume, and in these cases max_dB may be negative yet still valid. Here's an example: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/292#note_671300 Part-of: --- src/modules/alsa/alsa-mixer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/alsa/alsa-mixer.c b/src/modules/alsa/alsa-mixer.c index 1cfc42633..0bbac262e 100644 --- a/src/modules/alsa/alsa-mixer.c +++ b/src/modules/alsa/alsa-mixer.c @@ -1712,7 +1712,7 @@ static bool element_probe_volume(pa_alsa_element *e, snd_mixer_elem_t *me) { e->has_dB = snd_mixer_selem_get_capture_dB_range(me, &min_dB, &max_dB) >= 0; /* Assume decibel data to be incorrect if max_dB is negative. */ - if (e->has_dB && max_dB < 0) { + if (e->has_dB && max_dB < 0 && !e->db_fix) { pa_alsa_mixer_id_to_string(buf, sizeof(buf), &e->alsa_id); pa_log_warn("The decibel volume range for element %s (%li dB - %li dB) has negative maximum. " "Disabling the decibel range.", buf, min_dB, max_dB);