From aa3a27d5cdad9dd43b9fe79a13fd09b50d4b7682 Mon Sep 17 00:00:00 2001 From: "Alexander E. Patrakov" Date: Wed, 11 Feb 2015 21:50:47 +0500 Subject: [PATCH] module-loopback: don't use 0 for custom source output message id Message id 0 is PA_SOURCE_OUTPUT_MESSAGE_GET_LATENCY. So, every time PulseAudio sent PA_SOURCE_OUTPUT_MESSAGE_GET_LATENCY message to the loopback source output, it actually hit the SOURCE_OUTPUT_MESSAGE_LATENCY_SNAPSHOT handler instead. As a result, the SOURCE_OUTPUT_MESSAGE_LATENCY_SNAPSHOT handler was called when not intended, the default PA_SOURCE_OUTPUT_MESSAGE_GET_LATENCY handler was not called at all, and the latency was thus evaluated incorrectly. Reported-by: Georg Chini Signed-off-by: Alexander E. Patrakov --- src/modules/module-loopback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/module-loopback.c b/src/modules/module-loopback.c index 7e2b92a9b..3b0d68d20 100644 --- a/src/modules/module-loopback.c +++ b/src/modules/module-loopback.c @@ -126,7 +126,7 @@ enum { }; enum { - SOURCE_OUTPUT_MESSAGE_LATENCY_SNAPSHOT + SOURCE_OUTPUT_MESSAGE_LATENCY_SNAPSHOT = PA_SOURCE_OUTPUT_MESSAGE_MAX, }; static void enable_adjust_timer(struct userdata *u, bool enable);