launch: Remove the already implicit After=pulseaudio.socket

Also clarify the comment as to what can actually happen here.
This commit is contained in:
Jan Alexander Steffens (heftig) 2016-09-09 22:09:35 +02:00 committed by Tanu Kaskinen
parent b8113d861f
commit a2f3a7bf4d

View file

@ -1,21 +1,19 @@
[Unit] [Unit]
Description=Sound Service Description=Sound Service
# We require pulseaudio.socket to be active before starting the daemon, for two # We require pulseaudio.socket to be active before starting the daemon, because
# reasons: # while it is possible to use the service without the socket, it is not clear
# why it would be desirable.
# #
# 1. There are no implicit dependencies between sockets and services, so # A user installing pulseaudio and doing `systemctl --user start pulseaudio`
# the socket, as set up by systemd will race with the socket, as set up # will not get the socket started, which might be confusing and problematic if
# by the pulseaudio daemon. This can cause the pulseaudio.socket unit to # the server is to be restarted later on, as the client autospawn feature
# fail (even though the pulseaudio service started just fine), which can # might kick in. Also, a start of the socket unit will fail, adding to the
# confuse users. # confusion.
# 2. While it is possible to use the service without the socket, it is not #
# clear why it would be desirable. And a user installing pulseaudio and # After=pulseaudio.socket is not needed, as it is already implicit in the
# doing `systemctl --user start pulseaudio` will not get the socket # socket-service relationship, see systemd.socket(5).
# started, which might be confusing and problematic if the server is to
# be restarted later on, as the client autospawn feature might kick in.
Requires=pulseaudio.socket Requires=pulseaudio.socket
After=pulseaudio.socket
[Service] [Service]
# Note that notify will only work if --daemonize=no # Note that notify will only work if --daemonize=no