From 9d640e4491772e9edacc802ac72ed49d1f86176f Mon Sep 17 00:00:00 2001 From: Tanu Kaskinen Date: Mon, 26 Mar 2012 14:52:27 +0300 Subject: [PATCH] dbus: Add an assertion to get rid of a warning from Coverity. Coverity thinks that sample can be NULL when it's dereferenced after this line. Adding an assertion doesn't hurt here (in my opinion), and that should get rid of the warning. --- src/modules/dbus/iface-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/dbus/iface-core.c b/src/modules/dbus/iface-core.c index 58abcb9f5..97a46a58d 100644 --- a/src/modules/dbus/iface-core.c +++ b/src/modules/dbus/iface-core.c @@ -1401,7 +1401,7 @@ static void handle_upload_sample(DBusConnection *conn, DBusMessage *msg, void *u goto finish; } - sample = pa_idxset_get_by_index(c->core->scache, idx); + pa_assert_se(sample = pa_idxset_get_by_index(c->core->scache, idx)); if (n_volume_entries > 0) { sample->volume.channels = n_channels;