From 976f7e9a61e026de9d976a7e35b13cdd0314b0a1 Mon Sep 17 00:00:00 2001 From: Peter Meerwald-Stadler Date: Tue, 7 Mar 2017 15:57:28 +0100 Subject: [PATCH] core: Assert return value of pa_shared_set/_remove() in dbus-shared it must succeed, or we are leaking memory Coverity ID: #1380674, #1380673 Signed-off-by: Peter Meerwald-Stadler --- src/pulsecore/dbus-shared.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pulsecore/dbus-shared.c b/src/pulsecore/dbus-shared.c index 935b068ca..3422c29a7 100644 --- a/src/pulsecore/dbus-shared.c +++ b/src/pulsecore/dbus-shared.c @@ -45,7 +45,7 @@ static pa_dbus_connection* dbus_connection_new(pa_core *c, pa_dbus_wrap_connecti pconn->property_name = name; pconn->connection = conn; - pa_shared_set(c, name, pconn); + pa_assert_se(pa_shared_set(c, name, pconn) >= 0); return pconn; } @@ -88,7 +88,7 @@ void pa_dbus_connection_unref(pa_dbus_connection *c) { pa_dbus_wrap_connection_free(c->connection); - pa_shared_remove(c->core, c->property_name); + pa_assert_se(pa_shared_remove(c->core, c->property_name) >= 0); pa_xfree(c); }