mirrors/pulseaudio
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git synced 2025-11-02 09:01:46 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

core, pulse, modules: Fix undefined behavior with array subscript of invalid type

Browse source 
From the NetBSD manual:

     The first argument of these functions is of type int, but only a very
     restricted subset of values are actually valid.  The argument must either
     be the value of the macro EOF (which has a negative value), or must be a
     non-negative value within the range representable as unsigned char.
     Passing invalid values leads to undefined behavior.

     --  ctype(3)
This commit is contained in:
Kamil Rytarowski 2015-11-20 04:20:36 +01:00 • committed by Arun Raghavan
parent 9dd77827ad
commit 93cccdee8d
5 changed files with 15 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/pulsecore/core-util.c
View file

@ -2332,7 +2332,7 @@ int pa_atou(const char *s, uint32_t *ret_u) {
pa_assert(ret_u);
/* strtoul() ignores leading spaces. We don't. */
if (isspace(*s)) {
if (isspace((unsigned char)*s)) {
errno = EINVAL;
return -1;
}
@ -2376,7 +2376,7 @@ int pa_atol(const char *s, long *ret_l) {
pa_assert(ret_l);
/* strtol() ignores leading spaces. We don't. */
if (isspace(*s)) {
if (isspace((unsigned char)*s)) {
errno = EINVAL;
return -1;
}
@ -2421,7 +2421,7 @@ int pa_atod(const char *s, double *ret_d) {
pa_assert(ret_d);
/* strtod() ignores leading spaces. We don't. */
if (isspace(*s)) {
if (isspace((unsigned char)*s)) {
errno = EINVAL;
return -1;
}