mirrors/pulseaudio
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git synced 2026-04-09 08:21:21 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

sink, source: Change the set_port() callback return value to void

Browse source 
The callback implementations didn't report any errors, so checking for
set_port() failure was pointless (and the reported error code was bogus,
PA_ERR_NOENTITY). The UCM set_port() implementation used to report
errors, but I removed that reporting too when I changed
pa_alsa_ucm_set_port() implementation to use
pa_alsa_ucm_port_enable_devices(), which doesn't report errors. I could
report errors from pa_alsa_ucm_port_enable_devices(), but I really don't
see much benefit in that.
This commit is contained in:
Tanu Kaskinen 2020-06-10 11:50:23 +03:00
parent dc0cf0afeb
commit 926722cb6a
9 changed files with 13 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/pulsecore/source.c
View file

@ -2686,8 +2686,7 @@ int pa_source_set_port(pa_source *s, const char *name, bool save) {
return 0;
}
if (s->set_port(s, port) < 0)
return -PA_ERR_NOENTITY;
s->set_port(s, port);
pa_subscription_post(s->core, PA_SUBSCRIPTION_EVENT_SOURCE|PA_SUBSCRIPTION_EVENT_CHANGE, s->index);