mirror of
				https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git
				synced 2025-11-03 09:01:50 -05:00 
			
		
		
		
	Add comments referring to bug #53709.
This commit is contained in:
		
							parent
							
								
									ff4af902cf
								
							
						
					
					
						commit
						9197c0323e
					
				
					 6 changed files with 30 additions and 0 deletions
				
			
		| 
						 | 
				
			
			@ -1128,6 +1128,8 @@ static void sink_input_update_max_rewind_cb(pa_sink_input *i, size_t nbytes) {
 | 
			
		|||
 | 
			
		||||
    pa_log_debug("Sink input update max rewind %lld", (long long) nbytes);
 | 
			
		||||
 | 
			
		||||
    /* FIXME: Too small max_rewind:
 | 
			
		||||
     * https://bugs.freedesktop.org/show_bug.cgi?id=53709 */
 | 
			
		||||
    pa_memblockq_set_maxrewind(u->sink_memblockq, nbytes);
 | 
			
		||||
    pa_sink_set_max_rewind_within_thread(u->sink, nbytes);
 | 
			
		||||
}
 | 
			
		||||
| 
						 | 
				
			
			@ -1277,6 +1279,9 @@ static void sink_input_attach_cb(pa_sink_input *i) {
 | 
			
		|||
     * pa_sink_input_get_max_request(i) UP TO MULTIPLES OF IT
 | 
			
		||||
     * HERE. SEE (6) */
 | 
			
		||||
    pa_sink_set_max_request_within_thread(u->sink, pa_sink_input_get_max_request(i));
 | 
			
		||||
 | 
			
		||||
    /* FIXME: Too small max_rewind:
 | 
			
		||||
     * https://bugs.freedesktop.org/show_bug.cgi?id=53709 */
 | 
			
		||||
    pa_sink_set_max_rewind_within_thread(u->sink, pa_sink_input_get_max_rewind(i));
 | 
			
		||||
 | 
			
		||||
    pa_log_debug("Sink input %d attach", i->index);
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -757,6 +757,8 @@ static void sink_input_update_max_rewind_cb(pa_sink_input *i, size_t nbytes) {
 | 
			
		|||
    pa_sink_input_assert_ref(i);
 | 
			
		||||
    pa_assert_se(u = i->userdata);
 | 
			
		||||
 | 
			
		||||
    /* FIXME: Too small max_rewind:
 | 
			
		||||
     * https://bugs.freedesktop.org/show_bug.cgi?id=53709 */
 | 
			
		||||
    pa_memblockq_set_maxrewind(u->input_q, nbytes);
 | 
			
		||||
    pa_sink_set_max_rewind_within_thread(u->sink, nbytes);
 | 
			
		||||
}
 | 
			
		||||
| 
						 | 
				
			
			@ -823,6 +825,9 @@ static void sink_input_attach_cb(pa_sink_input *i) {
 | 
			
		|||
    max_request = PA_MAX(max_request, u->window_size);
 | 
			
		||||
 | 
			
		||||
    pa_sink_set_max_request_within_thread(u->sink, max_request * fs);
 | 
			
		||||
 | 
			
		||||
    /* FIXME: Too small max_rewind:
 | 
			
		||||
     * https://bugs.freedesktop.org/show_bug.cgi?id=53709 */
 | 
			
		||||
    pa_sink_set_max_rewind_within_thread(u->sink, pa_sink_input_get_max_rewind(i));
 | 
			
		||||
 | 
			
		||||
    pa_sink_attach_within_thread(u->sink);
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -550,6 +550,8 @@ static void sink_input_update_max_rewind_cb(pa_sink_input *i, size_t nbytes) {
 | 
			
		|||
    pa_sink_input_assert_ref(i);
 | 
			
		||||
    pa_assert_se(u = i->userdata);
 | 
			
		||||
 | 
			
		||||
    /* FIXME: Too small max_rewind:
 | 
			
		||||
     * https://bugs.freedesktop.org/show_bug.cgi?id=53709 */
 | 
			
		||||
    pa_memblockq_set_maxrewind(u->memblockq, nbytes);
 | 
			
		||||
    pa_sink_set_max_rewind_within_thread(u->sink, nbytes);
 | 
			
		||||
}
 | 
			
		||||
| 
						 | 
				
			
			@ -607,6 +609,9 @@ static void sink_input_attach_cb(pa_sink_input *i) {
 | 
			
		|||
    pa_sink_set_latency_range_within_thread(u->sink, i->sink->thread_info.min_latency, i->sink->thread_info.max_latency);
 | 
			
		||||
    pa_sink_set_fixed_latency_within_thread(u->sink, i->sink->thread_info.fixed_latency);
 | 
			
		||||
    pa_sink_set_max_request_within_thread(u->sink, pa_sink_input_get_max_request(i));
 | 
			
		||||
 | 
			
		||||
    /* FIXME: Too small max_rewind:
 | 
			
		||||
     * https://bugs.freedesktop.org/show_bug.cgi?id=53709 */
 | 
			
		||||
    pa_sink_set_max_rewind_within_thread(u->sink, pa_sink_input_get_max_rewind(i));
 | 
			
		||||
 | 
			
		||||
    pa_sink_attach_within_thread(u->sink);
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -185,6 +185,8 @@ static void sink_input_update_max_rewind_cb(pa_sink_input *i, size_t nbytes) {
 | 
			
		|||
    pa_sink_input_assert_ref(i);
 | 
			
		||||
    pa_assert_se(u = i->userdata);
 | 
			
		||||
 | 
			
		||||
    /* FIXME: Too small max_rewind:
 | 
			
		||||
     * https://bugs.freedesktop.org/show_bug.cgi?id=53709 */
 | 
			
		||||
    pa_sink_set_max_rewind_within_thread(u->sink, nbytes);
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
| 
						 | 
				
			
			@ -241,6 +243,9 @@ static void sink_input_attach_cb(pa_sink_input *i) {
 | 
			
		|||
    pa_sink_set_latency_range_within_thread(u->sink, i->sink->thread_info.min_latency, i->sink->thread_info.max_latency);
 | 
			
		||||
    pa_sink_set_fixed_latency_within_thread(u->sink, i->sink->thread_info.fixed_latency);
 | 
			
		||||
    pa_sink_set_max_request_within_thread(u->sink, pa_sink_input_get_max_request(i));
 | 
			
		||||
 | 
			
		||||
    /* FIXME: Too small max_rewind:
 | 
			
		||||
     * https://bugs.freedesktop.org/show_bug.cgi?id=53709 */
 | 
			
		||||
    pa_sink_set_max_rewind_within_thread(u->sink, pa_sink_input_get_max_rewind(i));
 | 
			
		||||
 | 
			
		||||
    pa_sink_attach_within_thread(u->sink);
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -300,6 +300,8 @@ static void sink_input_update_max_rewind_cb(pa_sink_input *i, size_t nbytes) {
 | 
			
		|||
    pa_sink_input_assert_ref(i);
 | 
			
		||||
    pa_assert_se(u = i->userdata);
 | 
			
		||||
 | 
			
		||||
    /* FIXME: Too small max_rewind:
 | 
			
		||||
     * https://bugs.freedesktop.org/show_bug.cgi?id=53709 */
 | 
			
		||||
    pa_memblockq_set_maxrewind(u->memblockq, nbytes);
 | 
			
		||||
    pa_sink_set_max_rewind_within_thread(u->sink, nbytes);
 | 
			
		||||
}
 | 
			
		||||
| 
						 | 
				
			
			@ -371,6 +373,9 @@ static void sink_input_attach_cb(pa_sink_input *i) {
 | 
			
		|||
     * pa_sink_input_get_max_request(i) UP TO MULTIPLES OF IT
 | 
			
		||||
     * HERE. SEE (6) */
 | 
			
		||||
    pa_sink_set_max_request_within_thread(u->sink, pa_sink_input_get_max_request(i));
 | 
			
		||||
 | 
			
		||||
    /* FIXME: Too small max_rewind:
 | 
			
		||||
     * https://bugs.freedesktop.org/show_bug.cgi?id=53709 */
 | 
			
		||||
    pa_sink_set_max_rewind_within_thread(u->sink, pa_sink_input_get_max_rewind(i));
 | 
			
		||||
 | 
			
		||||
    pa_sink_attach_within_thread(u->sink);
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -322,6 +322,8 @@ static void sink_input_update_max_rewind_cb(pa_sink_input *i, size_t nbytes) {
 | 
			
		|||
    pa_sink_input_assert_ref(i);
 | 
			
		||||
    pa_assert_se(u = i->userdata);
 | 
			
		||||
 | 
			
		||||
    /* FIXME: Too small max_rewind:
 | 
			
		||||
     * https://bugs.freedesktop.org/show_bug.cgi?id=53709 */
 | 
			
		||||
    pa_memblockq_set_maxrewind(u->memblockq, nbytes * u->sink_fs / u->fs);
 | 
			
		||||
    pa_sink_set_max_rewind_within_thread(u->sink, nbytes * u->sink_fs / u->fs);
 | 
			
		||||
}
 | 
			
		||||
| 
						 | 
				
			
			@ -381,6 +383,9 @@ static void sink_input_attach_cb(pa_sink_input *i) {
 | 
			
		|||
    pa_sink_set_fixed_latency_within_thread(u->sink, i->sink->thread_info.fixed_latency);
 | 
			
		||||
 | 
			
		||||
    pa_sink_set_max_request_within_thread(u->sink, pa_sink_input_get_max_request(i));
 | 
			
		||||
 | 
			
		||||
    /* FIXME: Too small max_rewind:
 | 
			
		||||
     * https://bugs.freedesktop.org/show_bug.cgi?id=53709 */
 | 
			
		||||
    pa_sink_set_max_rewind_within_thread(u->sink, pa_sink_input_get_max_rewind(i));
 | 
			
		||||
 | 
			
		||||
    pa_sink_attach_within_thread(u->sink);
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue