mirror of
				https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git
				synced 2025-11-03 09:01:50 -05:00 
			
		
		
		
	various smaller cleanups
This commit is contained in:
		
							parent
							
								
									c8abe64040
								
							
						
					
					
						commit
						869341729f
					
				
					 2 changed files with 7 additions and 18 deletions
				
			
		| 
						 | 
					@ -1190,17 +1190,11 @@ static int process_rewind(struct userdata *u) {
 | 
				
			||||||
 | 
					
 | 
				
			||||||
    /* Figure out how much we shall rewind and reset the counter */
 | 
					    /* Figure out how much we shall rewind and reset the counter */
 | 
				
			||||||
    rewind_nbytes = u->sink->thread_info.rewind_nbytes;
 | 
					    rewind_nbytes = u->sink->thread_info.rewind_nbytes;
 | 
				
			||||||
    u->sink->thread_info.rewind_nbytes = 0;
 | 
					 | 
				
			||||||
 | 
					
 | 
				
			||||||
    if (rewind_nbytes <= 0)
 | 
					 | 
				
			||||||
        goto finish;
 | 
					 | 
				
			||||||
 | 
					 | 
				
			||||||
    pa_assert(rewind_nbytes > 0);
 | 
					 | 
				
			||||||
    pa_log_debug("Requested to rewind %lu bytes.", (unsigned long) rewind_nbytes);
 | 
					    pa_log_debug("Requested to rewind %lu bytes.", (unsigned long) rewind_nbytes);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
    snd_pcm_hwsync(u->pcm_handle);
 | 
					    if (PA_UNLIKELY((unused = pa_alsa_safe_avail(u->pcm_handle, u->hwbuf_size, &u->sink->sample_spec)) < 0)) {
 | 
				
			||||||
    if ((unused = snd_pcm_avail_update(u->pcm_handle)) < 0) {
 | 
					        pa_log("snd_pcm_avail() failed: %s", snd_strerror((int) unused));
 | 
				
			||||||
        pa_log("snd_pcm_avail_update() failed: %s", snd_strerror((int) unused));
 | 
					 | 
				
			||||||
        return -1;
 | 
					        return -1;
 | 
				
			||||||
    }
 | 
					    }
 | 
				
			||||||
 | 
					
 | 
				
			||||||
| 
						 | 
					@ -1242,12 +1236,8 @@ static int process_rewind(struct userdata *u) {
 | 
				
			||||||
    } else
 | 
					    } else
 | 
				
			||||||
        pa_log_debug("Mhmm, actually there is nothing to rewind.");
 | 
					        pa_log_debug("Mhmm, actually there is nothing to rewind.");
 | 
				
			||||||
 | 
					
 | 
				
			||||||
finish:
 | 
					 | 
				
			||||||
 | 
					 | 
				
			||||||
    pa_sink_process_rewind(u->sink, 0);
 | 
					    pa_sink_process_rewind(u->sink, 0);
 | 
				
			||||||
 | 
					 | 
				
			||||||
    return 0;
 | 
					    return 0;
 | 
				
			||||||
 | 
					 | 
				
			||||||
}
 | 
					}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
static void thread_func(void *userdata) {
 | 
					static void thread_func(void *userdata) {
 | 
				
			||||||
| 
						 | 
					@ -1276,7 +1266,7 @@ static void thread_func(void *userdata) {
 | 
				
			||||||
            int work_done;
 | 
					            int work_done;
 | 
				
			||||||
            pa_usec_t sleep_usec = 0;
 | 
					            pa_usec_t sleep_usec = 0;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
            if (u->sink->thread_info.rewind_requested)
 | 
					            if (PA_UNLIKELY(u->sink->thread_info.rewind_requested))
 | 
				
			||||||
                if (process_rewind(u) < 0)
 | 
					                if (process_rewind(u) < 0)
 | 
				
			||||||
                        goto fail;
 | 
					                        goto fail;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
| 
						 | 
					@ -1702,11 +1692,10 @@ pa_sink *pa_alsa_sink_new(pa_module *m, pa_modargs *ma, const char*driver, pa_ca
 | 
				
			||||||
        u->watermark_step = pa_usec_to_bytes(TSCHED_WATERMARK_STEP_USEC, &u->sink->sample_spec);
 | 
					        u->watermark_step = pa_usec_to_bytes(TSCHED_WATERMARK_STEP_USEC, &u->sink->sample_spec);
 | 
				
			||||||
    }
 | 
					    }
 | 
				
			||||||
 | 
					
 | 
				
			||||||
    u->sink->thread_info.max_rewind = use_tsched ? u->hwbuf_size : 0;
 | 
					    pa_sink_set_max_rewind(u->sink, use_tsched ? u->hwbuf_size : 0);
 | 
				
			||||||
    u->sink->thread_info.max_request = u->hwbuf_size;
 | 
					    pa_sink_set_max_request(u->sink, u->hwbuf_size);
 | 
				
			||||||
 | 
					 | 
				
			||||||
    pa_sink_set_latency_range(u->sink,
 | 
					    pa_sink_set_latency_range(u->sink,
 | 
				
			||||||
                              !use_tsched ? pa_bytes_to_usec(u->hwbuf_size, &ss) : (pa_usec_t) -1,
 | 
					                              use_tsched ? (pa_usec_t) -1 : pa_bytes_to_usec(u->hwbuf_size, &ss),
 | 
				
			||||||
                              pa_bytes_to_usec(u->hwbuf_size, &ss));
 | 
					                              pa_bytes_to_usec(u->hwbuf_size, &ss));
 | 
				
			||||||
 | 
					
 | 
				
			||||||
    pa_log_info("Using %u fragments of size %lu bytes, buffer time is %0.2fms",
 | 
					    pa_log_info("Using %u fragments of size %lu bytes, buffer time is %0.2fms",
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
| 
						 | 
					@ -1545,7 +1545,7 @@ pa_source *pa_alsa_source_new(pa_module *m, pa_modargs *ma, const char*driver, p
 | 
				
			||||||
    }
 | 
					    }
 | 
				
			||||||
 | 
					
 | 
				
			||||||
    pa_source_set_latency_range(u->source,
 | 
					    pa_source_set_latency_range(u->source,
 | 
				
			||||||
                                !use_tsched ? pa_bytes_to_usec(u->hwbuf_size, &ss) : (pa_usec_t) -1,
 | 
					                                use_tsched ? (pa_usec_t) -1 : pa_bytes_to_usec(u->hwbuf_size, &ss),
 | 
				
			||||||
                                pa_bytes_to_usec(u->hwbuf_size, &ss));
 | 
					                                pa_bytes_to_usec(u->hwbuf_size, &ss));
 | 
				
			||||||
 | 
					
 | 
				
			||||||
    pa_log_info("Using %u fragments of size %lu bytes, buffer time is %0.2fms",
 | 
					    pa_log_info("Using %u fragments of size %lu bytes, buffer time is %0.2fms",
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue