mirrors/pulseaudio
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git synced 2025-10-29 05:40:23 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

tests: Don't run volume tests with impossible alignments

Browse source 
This worked so far somehow, but we were sending in some samples at
unrealistic alignments (given that pa_memblockq will be frame-aligned,
and we expect all operations to occur per-frame as well).

Fixes: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/issues/3803
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/812>
This commit is contained in:
Arun Raghavan 2024-03-22 09:31:48 -04:00
parent 21d7a63e8c
commit 84f5b742e3
1 changed files with 16 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

33
src/tests/cpu-volume-test.c
View file

@ -43,6 +43,7 @@ static void run_volume_test(
int channels,
bool correct,
bool perf) {
fail_unless(align % channels == 0);
PA_DECLARE_ALIGNED(8, int16_t, s[SAMPLES]) = { 0 };
PA_DECLARE_ALIGNED(8, int16_t, s_ref[SAMPLES]) = { 0 };
@ -56,8 +57,6 @@ static void run_volume_test(
samples_ref = s_ref + (8 - align);
samples_orig = s_orig + (8 - align);
nsamples = SAMPLES - (8 - align);
if (nsamples % channels)
nsamples -= nsamples % channels;
size = nsamples * sizeof(int16_t);
pa_random(samples, size);
@ -119,12 +118,12 @@ START_TEST (svolume_mmx_test) {
pa_log_debug("Checking MMX svolume");
for (i = 1; i <= 3; i++) {
for (j = 0; j < 7; j++)
run_volume_test(mmx_func, orig_func, j, i, true, false);
for (j = 0; j <= 7; j += i)
run_volume_test(mmx_func, orig_func, j, i, true, j == 0);
}
run_volume_test(mmx_func, orig_func, 7, 1, true, true);
run_volume_test(mmx_func, orig_func, 7, 2, true, true);
run_volume_test(mmx_func, orig_func, 7, 3, true, true);
run_volume_test(mmx_func, orig_func, 6, 2, true, true);
run_volume_test(mmx_func, orig_func, 6, 3, true, true);
}
END_TEST
@ -146,12 +145,12 @@ START_TEST (svolume_sse_test) {
pa_log_debug("Checking SSE2 svolume");
for (i = 1; i <= 3; i++) {
for (j = 0; j < 7; j++)
run_volume_test(sse_func, orig_func, j, i, true, false);
for (j = 0; j < 7; j += i)
run_volume_test(sse_func, orig_func, j, i, true, j == 0);
}
run_volume_test(sse_func, orig_func, 7, 1, true, true);
run_volume_test(sse_func, orig_func, 7, 2, true, true);
run_volume_test(sse_func, orig_func, 7, 3, true, true);
run_volume_test(sse_func, orig_func, 6, 2, true, true);
run_volume_test(sse_func, orig_func, 6, 3, true, true);
}
END_TEST
#endif /* defined (__i386__) || defined (__amd64__) */
@ -175,12 +174,12 @@ START_TEST (svolume_arm_test) {
pa_log_debug("Checking ARM svolume");
for (i = 1; i <= 3; i++) {
for (j = 0; j < 7; j++)
run_volume_test(arm_func, orig_func, j, i, true, false);
for (j = 0; j < 7; j += i)
run_volume_test(arm_func, orig_func, j, i, true, j == 0);
}
run_volume_test(arm_func, orig_func, 7, 1, true, true);
run_volume_test(arm_func, orig_func, 7, 2, true, true);
run_volume_test(arm_func, orig_func, 7, 3, true, true);
run_volume_test(arm_func, orig_func, 6, 2, true, true);
run_volume_test(arm_func, orig_func, 6, 3, true, true);
}
END_TEST
#endif /* defined (__arm__) && defined (__linux__) */
@ -207,11 +206,11 @@ START_TEST (svolume_orc_test) {
pa_log_debug("Checking Orc svolume");
for (i = 1; i <= 2; i++) {
for (j = 0; j < 7; j++)
run_volume_test(orc_func, orig_func, j, i, true, false);
for (j = 0; j < 7; j += i)
run_volume_test(orc_func, orig_func, j, i, true, j == 0);
}
run_volume_test(orc_func, orig_func, 7, 1, true, true);
run_volume_test(orc_func, orig_func, 7, 2, true, true);
run_volume_test(orc_func, orig_func, 6, 2, true, true);
}
END_TEST