mirrors/pulseaudio
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git synced 2025-11-02 09:01:46 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

bluetooth: Fix sending D-Bus reply before internal callback

Browse source 
Make sure the reply to SetConfiguration() is sent before the internal
hook is fired. This is important because the hook could have side
effects including D-Bus interfactions (i.e. transport Acquire() being
called during module startup).
This commit is contained in:
Mikel Astiz 2013-01-24 10:16:57 +01:00 • committed by Tanu Kaskinen
parent 132814f114
commit 80406eba43
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/modules/bluetooth/bluetooth-util.c
View file

@ -1356,11 +1356,13 @@ static DBusMessage *endpoint_set_configuration(DBusConnection *conn, DBusMessage
pa_log_debug("Transport %s profile %d available", t->path, t->profile); pa_log_debug("Transport %s profile %d available", t->path, t->profile);
pa_assert_se(r = dbus_message_new_method_return(m)); pa_assert_se(r = dbus_message_new_method_return(m));
pa_assert_se(dbus_connection_send(pa_dbus_connection_get(y->connection), r, NULL));
dbus_message_unref(r);
if (old_any_connected != pa_bluetooth_device_any_audio_connected(d)) if (old_any_connected != pa_bluetooth_device_any_audio_connected(d))
run_callback(d, false); run_callback(d, false);
return r; return NULL;
fail: fail:
pa_log("org.bluez.MediaEndpoint.SetConfiguration: invalid arguments"); pa_log("org.bluez.MediaEndpoint.SetConfiguration: invalid arguments");