mirrors/pulseaudio
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git synced 2025-11-03 09:01:50 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

raop: Merge TCP and UDP code paths + refactoring

Browse source 
TCP and UDP implementation are following two diffrent code path while code
logic is quite the same. This patch merges both code path into a unique one
and, thus, leads to a big refactoring. Major changes include:
  - moving sink implementation to a separate file (raop-sink.c)
  - move raop-sink.c protocol specific code to raop-client.c
  - modernise RTSP session handling in TCP mode
  - reduce code duplications between TCP and UDP modes
  - introduce authentication support
  - TCP mode does not constantly send silent audio anymore

About authentication: OPTIONS is now issued when the sink is preliminary
loaded. Client authentication appends at that time and credential is kept
for the whole sink lifetime. Later RTSP connection will thus look like this:
ANNOUNCE > 200 OK > SETUP > 200 OK > RECORD > 200 OK (no more OPTIONS). This
behaviour is similar to iTunes one.

Also this patch includes file name changes to match Pulseaudio naming
rules, as most of pulseaudio source code files seem to be using '-'
instead of '_' as a word separator.
This commit is contained in:
Martin Blanchard 2016-11-06 12:54:07 -06:00 • committed by Tanu Kaskinen
parent 5ff21c3bdd
commit 8022e56581
16 changed files with 2557 additions and 2783 deletions
Download patch file Download diff file Expand all files Collapse all files

42
src/modules/raop/raop-packet-buffer.h Normal file
View file

@ -0,0 +1,42 @@
#ifndef RAOP_PACKET_BUFFER_H_INCLUDED
#define RAOP_PACKET_BUFFER_H_INCLUDED
/***
Circular buffer for RTP audio packets with random access support
by RTP sequence number.
Copyright 2013 Matthias Wabersich, Hajime Fujita
This is free software; you can redistribute it and/or modify
it under the terms of the GNU Lesser General Public License as published
by the Free Software Foundation; either version 2.1 of the License,
or (at your option) any later version.
This is distributed in the hope that it will be useful, but
WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
General Public License for more details.
You should have received a copy of the GNU Lesser General Public License
along with PulseAudio; if not, write to the Free Software
Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
USA.
***/
struct pa_raop_packet_element;
typedef struct pa_raop_packet_element pa_raop_packet_element;
struct pa_raop_packet_buffer;
typedef struct pa_raop_packet_buffer pa_raop_packet_buffer;
/* Allocates a new circular packet buffer
size: Maximum number of packets to store */
pa_raop_packet_buffer *pa_raop_pb_new(size_t size);
void pa_raop_pb_clear(pa_raop_packet_buffer *pb);
void pa_raop_pb_delete(pa_raop_packet_buffer *pb);
void pa_raop_pb_write_packet(pa_raop_packet_buffer *pb, uint16_t seq_num, const uint8_t *packet_data, ssize_t packet_length);
ssize_t pa_raop_pb_read_packet(pa_raop_packet_buffer *pb, uint16_t seq_num, uint8_t **packet_data);
#endif /* RAOP_PACKET_BUFFER_H_INCLUDED */