mirror of
				https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git
				synced 2025-11-03 09:01:50 -05:00 
			
		
		
		
	alsa: fix minor sampling rate deviations before adjusting the buffer size
This commit is contained in:
		
							parent
							
								
									366e3ebe19
								
							
						
					
					
						commit
						7ab8e83cb0
					
				
					 1 changed files with 9 additions and 7 deletions
				
			
		| 
						 | 
					@ -259,6 +259,10 @@ int pa_alsa_set_hw_params(
 | 
				
			||||||
        goto finish;
 | 
					        goto finish;
 | 
				
			||||||
    }
 | 
					    }
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /* We ignore very small sampling rate deviations */
 | 
				
			||||||
 | 
					    if (_ss.rate >= ss->rate*.95 && _ss.rate <= ss->rate*1.05)
 | 
				
			||||||
 | 
					        _ss.rate = ss->rate;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
    if (require_exact_channel_number) {
 | 
					    if (require_exact_channel_number) {
 | 
				
			||||||
        if ((ret = snd_pcm_hw_params_set_channels(pcm_handle, hwparams, _ss.channels)) < 0) {
 | 
					        if ((ret = snd_pcm_hw_params_set_channels(pcm_handle, hwparams, _ss.channels)) < 0) {
 | 
				
			||||||
            pa_log_debug("snd_pcm_hw_params_set_channels(%u) failed: %s", _ss.channels, pa_alsa_strerror(ret));
 | 
					            pa_log_debug("snd_pcm_hw_params_set_channels(%u) failed: %s", _ss.channels, pa_alsa_strerror(ret));
 | 
				
			||||||
| 
						 | 
					@ -303,7 +307,7 @@ int pa_alsa_set_hw_params(
 | 
				
			||||||
            if (set_buffer_size(pcm_handle, hwparams_copy, _buffer_size) >= 0 &&
 | 
					            if (set_buffer_size(pcm_handle, hwparams_copy, _buffer_size) >= 0 &&
 | 
				
			||||||
                set_period_size(pcm_handle, hwparams_copy, _period_size) >= 0 &&
 | 
					                set_period_size(pcm_handle, hwparams_copy, _period_size) >= 0 &&
 | 
				
			||||||
                snd_pcm_hw_params(pcm_handle, hwparams_copy) >= 0) {
 | 
					                snd_pcm_hw_params(pcm_handle, hwparams_copy) >= 0) {
 | 
				
			||||||
                pa_log_debug("Set buffer size first, period size second.");
 | 
					                pa_log_debug("Set buffer size first (to %lu samples), period size second (to %lu samples).", (unsigned long) _buffer_size, (unsigned long) _period_size);
 | 
				
			||||||
                goto success;
 | 
					                goto success;
 | 
				
			||||||
            }
 | 
					            }
 | 
				
			||||||
 | 
					
 | 
				
			||||||
| 
						 | 
					@ -311,7 +315,7 @@ int pa_alsa_set_hw_params(
 | 
				
			||||||
            if (set_period_size(pcm_handle, hwparams_copy, _period_size) >= 0 &&
 | 
					            if (set_period_size(pcm_handle, hwparams_copy, _period_size) >= 0 &&
 | 
				
			||||||
                set_buffer_size(pcm_handle, hwparams_copy, _buffer_size) >= 0 &&
 | 
					                set_buffer_size(pcm_handle, hwparams_copy, _buffer_size) >= 0 &&
 | 
				
			||||||
                snd_pcm_hw_params(pcm_handle, hwparams_copy) >= 0) {
 | 
					                snd_pcm_hw_params(pcm_handle, hwparams_copy) >= 0) {
 | 
				
			||||||
                pa_log_debug("Set period size first, buffer size second.");
 | 
					                pa_log_debug("Set period size first (to %lu samples), buffer size second (to %lu samples).", (unsigned long) _period_size, (unsigned long) _buffer_size);
 | 
				
			||||||
                goto success;
 | 
					                goto success;
 | 
				
			||||||
            }
 | 
					            }
 | 
				
			||||||
        }
 | 
					        }
 | 
				
			||||||
| 
						 | 
					@ -322,7 +326,7 @@ int pa_alsa_set_hw_params(
 | 
				
			||||||
            /* Third try: set only buffer size */
 | 
					            /* Third try: set only buffer size */
 | 
				
			||||||
            if (set_buffer_size(pcm_handle, hwparams_copy, _buffer_size) >= 0 &&
 | 
					            if (set_buffer_size(pcm_handle, hwparams_copy, _buffer_size) >= 0 &&
 | 
				
			||||||
                snd_pcm_hw_params(pcm_handle, hwparams_copy) >= 0) {
 | 
					                snd_pcm_hw_params(pcm_handle, hwparams_copy) >= 0) {
 | 
				
			||||||
                pa_log_debug("Set only buffer size second.");
 | 
					                pa_log_debug("Set only buffer size (to %lu samples).", (unsigned long) _buffer_size);
 | 
				
			||||||
                goto success;
 | 
					                goto success;
 | 
				
			||||||
            }
 | 
					            }
 | 
				
			||||||
        }
 | 
					        }
 | 
				
			||||||
| 
						 | 
					@ -333,7 +337,7 @@ int pa_alsa_set_hw_params(
 | 
				
			||||||
            /* Fourth try: set only period size */
 | 
					            /* Fourth try: set only period size */
 | 
				
			||||||
            if (set_period_size(pcm_handle, hwparams_copy, _period_size) >= 0 &&
 | 
					            if (set_period_size(pcm_handle, hwparams_copy, _period_size) >= 0 &&
 | 
				
			||||||
                snd_pcm_hw_params(pcm_handle, hwparams_copy) >= 0) {
 | 
					                snd_pcm_hw_params(pcm_handle, hwparams_copy) >= 0) {
 | 
				
			||||||
                pa_log_debug("Set only period size second.");
 | 
					                pa_log_debug("Set only period size (to %lu samples).", (unsigned long) _period_size);
 | 
				
			||||||
                goto success;
 | 
					                goto success;
 | 
				
			||||||
            }
 | 
					            }
 | 
				
			||||||
        }
 | 
					        }
 | 
				
			||||||
| 
						 | 
					@ -374,8 +378,6 @@ success:
 | 
				
			||||||
        goto finish;
 | 
					        goto finish;
 | 
				
			||||||
    }
 | 
					    }
 | 
				
			||||||
 | 
					
 | 
				
			||||||
    /* If the sample rate deviates too much, we need to resample */
 | 
					 | 
				
			||||||
    if (_ss.rate < ss->rate*.95 || _ss.rate > ss->rate*1.05)
 | 
					 | 
				
			||||||
    ss->rate = _ss.rate;
 | 
					    ss->rate = _ss.rate;
 | 
				
			||||||
    ss->channels = _ss.channels;
 | 
					    ss->channels = _ss.channels;
 | 
				
			||||||
    ss->format = _ss.format;
 | 
					    ss->format = _ss.format;
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue