From 77e73be925f47285d0f04ac4a753c6c8e1132144 Mon Sep 17 00:00:00 2001 From: Peter Meerwald Date: Thu, 24 May 2012 17:52:56 +0200 Subject: [PATCH] pipe: check return value of mkfifo() --- src/modules/module-pipe-sink.c | 5 ++++- src/modules/module-pipe-source.c | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/modules/module-pipe-sink.c b/src/modules/module-pipe-sink.c index fa0a080be..ef18fad6f 100644 --- a/src/modules/module-pipe-sink.c +++ b/src/modules/module-pipe-sink.c @@ -255,7 +255,10 @@ int pa__init(pa_module *m) { u->filename = pa_runtime_path(pa_modargs_get_value(ma, "file", DEFAULT_FILE_NAME)); - mkfifo(u->filename, 0666); + if (mkfifo(u->filename, 0666) < 0) { + pa_log("mkfifo('%s'): %s", u->filename, pa_cstrerror(errno)); + goto fail; + } if ((u->fd = pa_open_cloexec(u->filename, O_RDWR, 0)) < 0) { pa_log("open('%s'): %s", u->filename, pa_cstrerror(errno)); goto fail; diff --git a/src/modules/module-pipe-source.c b/src/modules/module-pipe-source.c index eb531d853..7a7dfb272 100644 --- a/src/modules/module-pipe-source.c +++ b/src/modules/module-pipe-source.c @@ -240,7 +240,10 @@ int pa__init(pa_module *m) { u->filename = pa_runtime_path(pa_modargs_get_value(ma, "file", DEFAULT_FILE_NAME)); - mkfifo(u->filename, 0666); + if (mkfifo(u->filename, 0666) < 0) { + pa_log("mkfifo('%s'): %s", u->filename, pa_cstrerror(errno)); + goto fail; + } if ((u->fd = pa_open_cloexec(u->filename, O_RDWR, 0)) < 0) { pa_log("open('%s'): %s", u->filename, pa_cstrerror(errno)); goto fail;