From 6b92027c194dc719c11f2fc39cfbdca2e5e2d5c4 Mon Sep 17 00:00:00 2001 From: Tanu Kaskinen Date: Thu, 9 Nov 2017 14:12:34 +0200 Subject: [PATCH] echo-cancel: fix a memory leak The pa_echo_canceller_msg object was never unreffed. --- src/modules/echo-cancel/module-echo-cancel.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/modules/echo-cancel/module-echo-cancel.c b/src/modules/echo-cancel/module-echo-cancel.c index ee3725abd..4fc837d2a 100644 --- a/src/modules/echo-cancel/module-echo-cancel.c +++ b/src/modules/echo-cancel/module-echo-cancel.c @@ -2164,8 +2164,10 @@ void pa__done(pa_module*m) { if (u->ec->done) u->ec->done(u->ec); - if (u->ec->msg) + if (u->ec->msg) { u->ec->msg->dead = true; + pa_echo_canceller_msg_unref(u->ec->msg); + } pa_xfree(u->ec); } @@ -2346,6 +2348,7 @@ int main(int argc, char* argv[]) { u.ec->done(u.ec); u.ec->msg->dead = true; + pa_echo_canceller_msg_unref(u.ec->msg); out: if (u.captured_file)