mirrors/pulseaudio
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git synced 2025-11-03 09:01:50 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

RTP segfault/uninitialized resampler

Browse source 
Erich Boleyn <erich@uruk.org> wrote:

> Using RTP for multi-room music streaming, updated to Pulse 0.9.14 from
> 0.9.9, RTP reception new crashes with a segfault on all machines at
> the first "Updating sample rate" log message.
>
> Source of the segfault appears to be null pointer for
> "impl_update_rates" function in resampler routine, perhaps
> uninitialized resamplers in general?

A fresh look after work made the resampler initialization code pop out.

The problem is in the sink connection being made from
"module-rtp-recv.c", the "PA_SINK_INPUT_VARIABLE_RATE" flag should be
passed into "pa_sink_input_new", but is not there.  Made the change and
tested it, fixes the problem.  Checked and head-of- tree off of the
pulseaudio.org source browsing link does not have this fix either.

One-liner patch attached.
This commit is contained in:
Erich Boleyn 2009-02-06 02:11:07 +01:00 • committed by Lennart Poettering
parent 6bb2c49057
commit 64926ff6b3
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/modules/rtp/module-rtp-recv.c
View file

@ -453,7 +453,7 @@ static struct session *session_new(struct userdata *u, const pa_sdp_info *sdp_in
data.module = u->module;
pa_sink_input_new_data_set_sample_spec(&data, &sdp_info->sample_spec);
pa_sink_input_new(&s->sink_input, u->module->core, &data, 0);
pa_sink_input_new(&s->sink_input, u->module->core, &data, PA_SINK_INPUT_VARIABLE_RATE);
pa_sink_input_new_data_done(&data);
if (!s->sink_input) {