mirrors/pulseaudio
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git synced 2025-11-03 09:01:50 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

sink, source: Add a TODO comment about removing get_formats()

Browse source
This commit is contained in:
Tanu Kaskinen 2013-11-17 21:22:20 +02:00
parent 5ddb486a8c
commit 5c860fe06d
2 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/pulsecore/sink.h
View file

@ -461,7 +461,13 @@ pa_queue *pa_sink_move_all_start(pa_sink *s, pa_queue *q);
void pa_sink_move_all_finish(pa_sink *s, pa_queue *q, bool save); void pa_sink_move_all_finish(pa_sink *s, pa_queue *q, bool save);
void pa_sink_move_all_fail(pa_queue *q); void pa_sink_move_all_fail(pa_queue *q);
/* Returns a copy of the sink formats. TODO: Get rid of this function (or at
* least get rid of the copying). There's no good reason to copy the formats
* every time someone wants to know what formats the sink supports. The formats
* idxset could be stored directly in the pa_sink struct.
* https://bugs.freedesktop.org/show_bug.cgi?id=71924 */
pa_idxset* pa_sink_get_formats(pa_sink *s); pa_idxset* pa_sink_get_formats(pa_sink *s);
bool pa_sink_set_formats(pa_sink *s, pa_idxset *formats); bool pa_sink_set_formats(pa_sink *s, pa_idxset *formats);
bool pa_sink_check_format(pa_sink *s, pa_format_info *f); bool pa_sink_check_format(pa_sink *s, pa_format_info *f);
pa_idxset* pa_sink_check_formats(pa_sink *s, pa_idxset *in_formats); pa_idxset* pa_sink_check_formats(pa_sink *s, pa_idxset *in_formats);

6
src/pulsecore/source.h
View file

@ -394,7 +394,13 @@ pa_queue *pa_source_move_all_start(pa_source *s, pa_queue *q);
void pa_source_move_all_finish(pa_source *s, pa_queue *q, bool save); void pa_source_move_all_finish(pa_source *s, pa_queue *q, bool save);
void pa_source_move_all_fail(pa_queue *q); void pa_source_move_all_fail(pa_queue *q);
/* Returns a copy of the source formats. TODO: Get rid of this function (or at
* least get rid of the copying). There's no good reason to copy the formats
* every time someone wants to know what formats the source supports. The
* formats idxset could be stored directly in the pa_source struct.
* https://bugs.freedesktop.org/show_bug.cgi?id=71924 */
pa_idxset* pa_source_get_formats(pa_source *s); pa_idxset* pa_source_get_formats(pa_source *s);
bool pa_source_check_format(pa_source *s, pa_format_info *f); bool pa_source_check_format(pa_source *s, pa_format_info *f);
pa_idxset* pa_source_check_formats(pa_source *s, pa_idxset *in_formats); pa_idxset* pa_source_check_formats(pa_source *s, pa_idxset *in_formats);