mirrors/pulseaudio
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git synced 2025-11-03 09:01:50 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

xcb: xcb_get_setup() can return 0, so make sure we check it before using

Browse source
This commit is contained in:
Colin Guthrie 2010-09-18 10:37:11 +01:00
parent 2c564f2e9e
commit 5c0bc09180
1 changed files with 48 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

40
src/pulsecore/x11prop.c
View file

@ -27,6 +27,8 @@
#include "x11prop.h"
#include <pulsecore/macro.h>
#include <xcb/xproto.h>
#include <xcb/xcb_atom.h>
@ -34,17 +36,34 @@
void pa_x11_set_prop(xcb_connection_t *xcb, const char *name, const char *data) {
xcb_screen_t *screen;
xcb_atom_t a = xcb_atom_get(xcb, name);
screen = xcb_setup_roots_iterator(xcb_get_setup(xcb)).data;
const xcb_setup_t *s;
xcb_atom_t a;
pa_assert(xcb);
pa_assert(name);
pa_assert(data);
if ((s = xcb_get_setup(xcb))) {
a = xcb_atom_get(xcb, name);
screen = xcb_setup_roots_iterator(s).data;
xcb_change_property(xcb, XCB_PROP_MODE_REPLACE, screen->root, a, STRING, PA_XCB_FORMAT, (int) strlen(data), (const void*) data);
}
}
void pa_x11_del_prop(xcb_connection_t *xcb, const char *name) {
xcb_screen_t *screen;
xcb_atom_t a = xcb_atom_get(xcb, name);
screen = xcb_setup_roots_iterator(xcb_get_setup(xcb)).data;
const xcb_setup_t *s;
xcb_atom_t a;
pa_assert(xcb);
pa_assert(name);
if ((s = xcb_get_setup(xcb))) {
a = xcb_atom_get(xcb, name);
screen = xcb_setup_roots_iterator(s).data;
xcb_delete_property(xcb, screen->root, a);
}
}
char* pa_x11_get_prop(xcb_connection_t *xcb, const char *name, char *p, size_t l) {
char *ret = NULL;
@ -52,8 +71,16 @@ char* pa_x11_get_prop(xcb_connection_t *xcb, const char *name, char *p, size_t l
xcb_get_property_cookie_t req;
xcb_get_property_reply_t* prop = NULL;
xcb_screen_t *screen;
xcb_atom_t a = xcb_atom_get(xcb, name);
screen = xcb_setup_roots_iterator(xcb_get_setup(xcb)).data;
const xcb_setup_t *s;
xcb_atom_t a;
pa_assert(xcb);
pa_assert(name);
pa_assert(p);
if ((s = xcb_get_setup(xcb))) {
a = xcb_atom_get(xcb, name);
screen = xcb_setup_roots_iterator(s).data;
req = xcb_get_property(xcb, 0, screen->root, a, STRING, 0, (uint32_t)(l-1));
prop = xcb_get_property_reply(xcb, req, NULL);
@ -72,6 +99,7 @@ char* pa_x11_get_prop(xcb_connection_t *xcb, const char *name, char *p, size_t l
p[len] = 0;
ret = p;
}
finish: