mirrors/pulseaudio
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pulseaudio/pulseaudio.git synced 2025-10-29 05:40:23 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

pipe-sink, pipe-source: fix file permissions

Browse source 
We recently changed the umask of the daemon from 022 to 077, which broke
module-pipe-sink in the system mode, because nobody was allowed to read
from the pipe.

module-pipe-source in the system mode was probably always broken,
because the old umask of 022 should prevent anyone from writing to the
pipe.

This patch uses chmod() after the file creation to set the permissions
to 0666, which is what the fkfifo() call tried to set.

Bug link: https://bugs.freedesktop.org/show_bug.cgi?id=107070
This commit is contained in:
Tanu Kaskinen 2018-07-04 13:40:12 +03:00
parent c7e5715075
commit 571ccc3318
2 changed files with 13 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/modules/module-pipe-sink.c
View file

@ -466,9 +466,15 @@ int pa__init(pa_module *m) {
pa_log("mkfifo('%s'): %s", u->filename, pa_cstrerror(errno));
goto fail;
}
} else
} else {
u->do_unlink_fifo = true;
/* Our umask is 077, so the pipe won't be created with the requested
* permissions. Let's fix the permissions with chmod(). */
if (chmod(u->filename, 0666) < 0)
pa_log_warn("chomd('%s'): %s", u->filename, pa_cstrerror(errno));
}
if ((u->fd = pa_open_cloexec(u->filename, O_RDWR, 0)) < 0) {
pa_log("open('%s'): %s", u->filename, pa_cstrerror(errno));
goto fail;

6
src/modules/module-pipe-source.c
View file

@ -243,7 +243,13 @@ int pa__init(pa_module *m) {
if (mkfifo(u->filename, 0666) < 0) {
pa_log("mkfifo('%s'): %s", u->filename, pa_cstrerror(errno));
goto fail;
} else {
/* Our umask is 077, so the pipe won't be created with the requested
* permissions. Let's fix the permissions with chmod(). */
if (chmod(u->filename, 0666) < 0)
pa_log_warn("chomd('%s'): %s", u->filename, pa_cstrerror(errno));
}
if ((u->fd = pa_open_cloexec(u->filename, O_RDWR, 0)) < 0) {
pa_log("open('%s'): %s", u->filename, pa_cstrerror(errno));
goto fail;